-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should persistence be customisable? #3
Comments
My intention is for it to apply for the whole origin and for it to apply permanently. I've updated the explainer to call this out and add the others as a question |
Reopening this to further any discussion that may be needed. |
Some sites update the theme until the next time the system changes. The API as it stands won't support that. Is this a use case we want to support? |
Wrt my previous comment the new/old requestOverride() function shape is such that an options object could be added that has a way to control the persistence. Strawman:
|
https://x.com/claviska/status/1771898152792043591?s=20 - provides an example of how you might want different behaviour for different types of site. |
A trinary option is what I have on https://colorcontrast.app as well. |
There are a few ways these settings could be set/saved, and it might make sense for this to be configurable:
Overwrites apply to: page/domain/host
Overwrites apply for the: session/permanently
The text was updated successfully, but these errors were encountered: