Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Find Blobs" doesn't expose convexity or inertia parameters #880

Open
fixermark opened this issue Jan 23, 2018 · 1 comment · May be fixed by #929
Open

"Find Blobs" doesn't expose convexity or inertia parameters #880

fixermark opened this issue Jan 23, 2018 · 1 comment · May be fixed by #929

Comments

@fixermark
Copy link

The "Find Blobs" operation lacks attachment for convexity or inertia parameters, and therefore uses the defaults from OpenCV (filterByInertia=true, minInertiaRatio=0.1f, maxInertiaRatio = MAX_FLOAT ; filterByConvexity = true; minConvexity = 0.95f; maxConvexity= MAX_FLOAT). As a result, the blob detector is biased for very smooth, closed blobs, making shapes like the attached very difficult to detect.

Exposing these options would make it easier to tune for oddly-shaped shapes.

nocontour
@JLLeitschuh
Copy link
Member

Would you be willing to open a PR with this change. I think you can add it to the bottom of the list of parameters without breaking the backwards compatibility of the save files.

@TheTripleV TheTripleV linked a pull request Mar 25, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add convexity and inertia ratio to findBlobs TheTripleV/GRIP
2 participants
@fixermark @JLLeitschuh