Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with wasi:http@0.2.0 snapshots #589

Open
ospencer opened this issue Mar 16, 2024 · 1 comment
Open

Inconsistency with wasi:http@0.2.0 snapshots #589

ospencer opened this issue Mar 16, 2024 · 1 comment

Comments

@ospencer
Copy link

It looks like the wasi:http@0.2.0 package in this repository only provides the proxy world, but the wasi:http@0.2.0 package over in https://github.com/WebAssembly/wasi-http/blob/main/wit/proxy.wit#L5 also provides the imports world.

This can confuse some tooling (and humans) because both (the same?) packages are versioned as 0.2.0 but don't supply the same worlds.

It'd be great if we could sync them now and then implement a way to ensure they stay in sync with future updates.

@ricochet
Copy link

It looks like we brought over the tagged version of the package which is what I'd expect:
https://github.com/WebAssembly/wasi-http/blob/v0.2.0/wit/proxy.wit#L5

Then later new changes came onto main that would be really great to get in and have these two synchronized. The good news is that adding a world that brings in the imports then is unioned with wasi:http/proxy, this will be purely-additive and backwards compatible.

We should fix sooner rather than later (perhaps 0.2.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants