Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Outlining] Consider replacing state enum with a single IRBuilder* currBuilder field #6113

Open
ashleynh opened this issue Nov 13, 2023 · 0 comments
Open

[Outlining] Consider replacing state enum with a single IRBuilder* currBuilder field #6113

ashleynh opened this issue Nov 13, 2023 · 0 comments
Assignees
@ashleynh

Comments

@ashleynh
Copy link
Collaborator 

          Just realized that it would be possible to replace this state enum with a single `IRBuilder* currBuilder` field that is either `&outlinedBuilder`, `&existingBuilder`, or `nullptr`. `getCurrentState` would simply set `currBuilder` to the correct value and we wouldn't need to worry about separately computing the right `IRBuilder` to use.

Up to you whether you want to do this, since the explicit state enum is slightly more self-documenting.

Originally posted by @tlively in #6110 (comment)
@ashleynh ashleynh self-assigned this Nov 13, 2023
@ashleynh ashleynh mentioned this issue Nov 13, 2023
Merged
@ashleynh ashleynh changed the title Consider replacing Outlining state enum with a single IRBuilder* currBuilder field [Outlining] Consider replacing state enum with a single IRBuilder* currBuilder field Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashleynh ashleynh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ashleynh