Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shared tests to separate files #187

Open
sunfishcode opened this issue Feb 14, 2022 · 1 comment
Open

Move shared tests to separate files #187

sunfishcode opened this issue Feb 14, 2022 · 1 comment

Comments

@sunfishcode
Copy link
Member

Currently, this threads proposal repo adds shared memory tests to existing test files in test/core: memory.wast, imports.wast, and exports.wast. For example:

https://github.com/WebAssembly/threads/blob/main/test/core/memory.wast#L9

However, not all wasm engines are expected to implement this threads proposal in its current form, even once it's standardized, some because of the nondeterminism, and some because of the effective dependency on Web Worker-style threads.

Would it make sense to move the tests for shared memory into separate files, so that engines which don't implement shared memories can easily filter them? This would be similar to the SIMD tests, which are all named simd_*.wast.

@rossberg
Copy link
Member

I agree, and would go even further. As with the simd tests, we should have a subdirectory threads, and all related tests should go there. Similarly for other non-trivial and possibly profile-dependent feature proposals, like exceptions, gc, continuations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants