Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec tests with memory offsets #223

Open
anuraaga opened this issue Feb 15, 2024 · 1 comment
Open

Spec tests with memory offsets #223

anuraaga opened this issue Feb 15, 2024 · 1 comment

Comments

@anuraaga
Copy link

While working on implementation of atomics, I noticed that the spec tests from here passed despite the logic being trivially broken by ignoring const offsets on memory addresses. While I don't know what the coverage goal of spec tests is, const offsets seem like they may be worth having tests for to make it easier to write correct implementations.

@dschuff
Copy link
Member

dschuff commented Feb 15, 2024

I think it would definitely be worth adding test coverage for this. Did you end up writing any that you'd be willing to contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants