Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threads: enable pthread_join #336

Merged
merged 1 commit into from
Oct 10, 2022
Merged

threads: enable pthread_join #336

merged 1 commit into from
Oct 10, 2022
+11 −0

Conversation

loganek
Copy link
Contributor

@loganek loganek commented Oct 10, 2022

No description provided.

@loganek
threads: enable pthread_join

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
77bd82d
abrown
abrown approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I have some doubts about whether __pthread_setcancelstate here even needs to be (or should be) called but I think it is fine for now. And this free looks right; the pthread_create is doing the malloc.

@abrown abrown merged commit 9d2f5a8 into WebAssembly:main Oct 10, 2022
john-sharratt pushed a commit to john-sharratt/wasix-libc that referenced this pull request Mar 6, 2023
@loganek @john-sharratt
threads: enable pthread_join (WebAssembly#336)
86b2cab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100

@abrown abrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loganek @sbc100 @abrown