threads: Retrieve default stack size from __heap_base/__data_end #350
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Dec 2, 2022
loganek
force-pushed
the
loganek/default-stack-size
branch
from
336f6fe to
79a4360
Compare
sbc100
reviewed
Dec 2, 2022
loganek
force-pushed
the
loganek/default-stack-size
branch
from
df8ec15 to
60aba3b
Compare
sbc100
reviewed
Dec 5, 2022
loganek
force-pushed
the
loganek/default-stack-size
branch
from
60aba3b to
7a7005a
Compare
sbc100
approved these changes
Dec 8, 2022
|
I was about to merge this but now it has a merge conflict; @loganek, can you resolve that? |
When compiling with `-z stack-size` flag, only the main thread's stack size is set to the specified value and other threads use musl's default value. That's inconsistent with LLD's `-Wl,-stack_size`. I think we can make it similar to MUSL's behavior, where thread's stack size can be set via `PT_GNU_STACK` program header (via `-Wl,-z,stack-size` flag). Configuring stack size through `pthread_attr_t` still work as expected and overrides the defaults ([pthread_create.c](https://github.com/WebAssembly/wasi-libc/blob/be1ffd6a9eba1704085987482557c2a32724227f/libc-top-half/musl/src/thread/pthread_create.c#L362)) default settings.
… they're defined
… of the memory I.e. when `--stack-first` flag is provided to the linker
loganek
force-pushed
the
loganek/default-stack-size
branch
from
7a7005a to
f768d5a
Compare
|
@abrown should be ready for merge now |
loganek
changed the title
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
…Assembly#350) When compiling with `-z stack-size` flag, only the main thread's stack size is set to the specified value and other threads use musl's default value. That's inconsistent with LLD's `-Wl,-stack_size`. I think we can make it similar to MUSL's behavior, where thread's stack size can be set via `PT_GNU_STACK` program header (via `-Wl,-z,stack-size` flag). Configuring stack size through `pthread_attr_t` still work as expected and overrides the defaults ([pthread_create.c](https://github.com/WebAssembly/wasi-libc/blob/be1ffd6a9eba1704085987482557c2a32724227f/libc-top-half/musl/src/thread/pthread_create.c#L362)) default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with
-z stack-sizeflag, only the main thread's stack size is set to the specified value and other threads use musl's default value. That's inconsistent with LLD's-Wl,-stack_size.I think we can make it similar to musl's behavior, where thread's stack size can be set via
PT_GNU_STACKprogram header (via-Wl,-z,stack-sizeflag).Configuring stack size through
pthread_attr_tstill works as expected and overrides the defaults (pthread_create.c).