__wasi_thread_spawn: stop truncating the return value #353
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Dec 7, 2022
| int32_t ret = __imported_wasi_thread_spawn((int32_t) start_arg); | ||
| return (uint16_t) ret; | ||
| int32_t __wasi_thread_spawn(void* start_arg) { | ||
| return __imported_wasi_thread_spawn((int32_t) start_arg); |
There was a problem hiding this comment.
Should we match the indentation that is used in the rest of this file?
as __wasi_errno_t is uint16_t, with the current coding, __pthread_create will never see negative return values from wasi:thread_spawn. eg. (int)(uint16_t)-1 == 65535.
yamt
force-pushed
the
wasi_thread_spawn-error
branch
from
f2af4dc to
f194c40
Compare
it's documented as `a negative error code.' |
sbc100
approved these changes
Dec 7, 2022
abrown
approved these changes
Dec 7, 2022
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
as __wasi_errno_t is uint16_t, with the current coding, __pthread_create will never see negative return values from wasi:thread_spawn. eg. (int)(uint16_t)-1 == 65535.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as __wasi_errno_t is uint16_t, with the current coding, __pthread_create will never see negative return values from wasi:thread_spawn.
eg. (int)(uint16_t)-1 == 65535.