threads: enable access to pthread_barrier_* functions
#358
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In building some `libc-test` tests, I found these functions were not compiled in. This change adds `pthread_barrier_init`, `pthread_barrier_wait`, and `pthread_barrier_destroy` to the `THREAD_MODEL=posix` build. As has been done with previous pthreads PRs, this PR skips any inter-process locking by removing any calls to `__vm_lock` and friends. If in the future WASI gains the "process" concept, then these locations (and the pre-existing ones) will need to be modified.
loganek
approved these changes
Dec 9, 2022
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
) In building some `libc-test` tests, I found these functions were not compiled in. This change adds `pthread_barrier_init`, `pthread_barrier_wait`, and `pthread_barrier_destroy` to the `THREAD_MODEL=posix` build. As has been done with previous pthreads PRs, this PR skips any inter-process locking by removing any calls to `__vm_lock` and friends. If in the future WASI gains the "process" concept, then these locations (and the pre-existing ones) will need to be modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In building some
libc-testtests, I found these functions were not compiled in. This change addspthread_barrier_init,pthread_barrier_wait, andpthread_barrier_destroyto theTHREAD_MODEL=posixbuild. As has been done with previous pthreads PRs, this PR skips any inter-process locking by removing any calls to__vm_lockand friends. If in the future WASI gains the "process" concept, then these locations (and the pre-existing ones) will need to be modified.