Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce over-allocation of stack #365

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Reduce over-allocation of stack #365

merged 2 commits into from
Dec 19, 2022

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Dec 17, 2022

No description provided.

yamt added 2 commits December 18, 2022 00:44

Verified

This commit was signed with the committer’s verified signature.
wpoynter Will Poynter
Stack guard w/o mprotect doesn't make much sense.

Verified

This commit was signed with the committer’s verified signature.
wpoynter Will Poynter
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps should be titled something like "reduce over-allocation of stack"?

@yamt yamt changed the title Reduce stacksize Reduce over-allocation of stack Dec 19, 2022
@yamt
Copy link
Contributor Author

yamt commented Dec 19, 2022

Perhaps should be titled something like "reduce over-allocation of stack"?

sure. i changed the title of the PR.

@sbc100 sbc100 merged commit dfad6fe into WebAssembly:main Dec 19, 2022
john-sharratt pushed a commit to john-sharratt/wasix-libc that referenced this pull request Mar 6, 2023
* Disable stack guard
* Stop rounding up stack size to PAGE_SIZE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants