wasi_thread_start: add a comment #371
Conversation
probably yes. |
once the api/abi got stable. |
| * Note: it's fragile to implement wasi_thread_start in C. | ||
| * On entry, we don't even have C stack (__stack_pointer) | ||
| * set up. Be careful when modifying this function. | ||
| */ |
There was a problem hiding this comment.
I actually wonder if the function, even in its current state, is safe and won't cause memory corruption? Whatever value is currently set to __stack_pointer is not correct; I'd assume the function will reference another thread's (main thread's?) stack (e.g. for local variables?) and overwrite the data. I presume it depends on the compiler or even it's optimization flags. Am I missing something?
There was a problem hiding this comment.
I presume it depends on the compiler or even it's optimization flags.
right. it's what i meant by "fragile".
when i disassembled it, it seemed ok. so i didn't bother to rewrite it in asm for now.
There was a problem hiding this comment.
Yeah, I guess this depends on the optimization level, if you exclude -O2 it actually does include stack operations. I was going to fix that in some of the WAMR examples by implementing the method in asm but then I notice @sbc100 's comment and your followup PR. Thansk.
No description provided.