Add a check to reactor modules to ensure _initialize is only called once #388
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Jan 25, 2023
TerrorJack
force-pushed
the
reactor-initialize-runonce-check
branch
from
149319f to
a5dc0c1
Compare
sbc100
reviewed
Jan 26, 2023
There was a problem hiding this comment.
Seems reasonable to me. I'll wait @sunfishcode for chime in too though.
|
Sounds like a good idea to me. We should also add code to do this with atomics when |
Calling _initialize multiple times is undefined behavior, since the ctors are not guaranteed to be idempotent. We should have this safety check which is similar to #329.
TerrorJack
force-pushed
the
reactor-initialize-runonce-check
branch
from
a5dc0c1 to
7c4c731
Compare
|
@sunfishcode The check logic when |
|
Thanks! |
abrown
added a commit
to abrown/wasi-sdk
that referenced
this pull request
Feb 7, 2023
This brings in two recent commits, WebAssembly/wasi-libc#388 and WebAssembly/wasi-libc#391, that seem useful to have.
abrown
added a commit
to WebAssembly/wasi-sdk
that referenced
this pull request
Feb 10, 2023
This brings in two recent commits, WebAssembly/wasi-libc#388 and WebAssembly/wasi-libc#391, that seem useful to have.
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
…nce (WebAssembly#388) Calling _initialize multiple times is undefined behavior, since the ctors are not guaranteed to be idempotent. We should have this safety check which is similar to WebAssembly#329.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling _initialize multiple times is undefined behavior, since the ctors are not guaranteed to be idempotent. We should have this safety check which is similar to #329.