Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_default_stack_size: set __default_stacksize unconditionally #396

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Feb 21, 2023

If a user specifies a small stack size for the main, maybe it's reasonable to use the same size for threads as well.

stack_size : DEFAULT_STACK_MAX;
__default_stacksize =
stack_size < DEFAULT_STACK_MAX ?
stack_size : DEFAULT_STACK_MAX;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense but should we bracket it with #ifdef __wasilibc_unmodified_upstream?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole thing is already guarded by __wasilibc_unmodified_upstream (line 18). Just a minor note - you use spaces, whereas the whole project uses tabs for indents, so better to keep it consistent (we might want to setup linters to do those checks automatically though).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fixed space vs tab issue

If a user specifies a small stack size for the main,
maybe it's reasonable to use the same size for threads as well.
@abrown abrown merged commit b67d6b2 into WebAssembly:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants