setup_default_stack_size: set __default_stacksize unconditionally #396
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
reviewed
Feb 22, 2023
| stack_size : DEFAULT_STACK_MAX; | ||
| __default_stacksize = | ||
| stack_size < DEFAULT_STACK_MAX ? | ||
| stack_size : DEFAULT_STACK_MAX; |
There was a problem hiding this comment.
I think this change makes sense but should we bracket it with #ifdef __wasilibc_unmodified_upstream?
There was a problem hiding this comment.
this whole thing is already guarded by __wasilibc_unmodified_upstream (line 18). Just a minor note - you use spaces, whereas the whole project uses tabs for indents, so better to keep it consistent (we might want to setup linters to do those checks automatically though).
There was a problem hiding this comment.
i fixed space vs tab issue
If a user specifies a small stack size for the main, maybe it's reasonable to use the same size for threads as well.
loganek
approved these changes
Feb 22, 2023
abrown
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user specifies a small stack size for the main, maybe it's reasonable to use the same size for threads as well.