Avoid using absolute pathnames in Makefile. NFC #400
Merged
+16
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
shorten_pathnames
branch
from
792fe6a to
0f610fb
Compare
abrown
approved these changes
Mar 2, 2023
This makes the output of the build a lot more concise and easy to read. The only real change here is to build each of the crt1 startup files individually instead to trying to build them all in a single clang invocation (that latter doesn't allow for -o to be specified which is a pretty severe limitation, so its best avoided anyway). It also reduces the size of the `ar` command line for libc itself from 78017 to 43609 (on my machine), which sadly is still tool long for win32 I believe.
sbc100
force-pushed
the
shorten_pathnames
branch
from
0f610fb to
b3db1fb
Compare
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
This makes the output of the build a lot more concise and easy to read. The only real change here is to build each of the crt1 startup files individually instead to trying to build them all in a single clang invocation (that latter doesn't allow for -o to be specified which is a pretty severe limitation, so its best avoided anyway). It also reduces the size of the `ar` command line for libc itself from 78017 to 43609 (on my machine), which sadly is still tool long for win32 I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the output of the build a lot more concise and easy to read.
The only real change here is to build each of the crt1 startup files individually instead to trying to build them all in a single clang invocation (that latter doesn't allow for -o to be specified which is a pretty severe limitation, so its best avoided anyway).
It also reduces the size of the
arcommand line for libc itself from 78017 to 43609 (on my machine), which sadly is still tool long for win32 I believe.