Fix debug build's predefined-macros.txt
#407
Merged
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the ability to build `wasi-libc` with `-g` options and possibly without `-O2` options as well. I've found this useful when debugging issues as historically that the build fails when `-g` is passed or optimizations are removed due to the checks against these expectation files. This commit adds more filters to the list of macros to ensure that optimization/debug related ones are all removed from the expectation lists.
|
Yes, this makes sense. The main use for the predefined macros files is to monitor changes to the very large set of macros that libc is expected to define, and so it's ok to trim some of the boring macros out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the ability to build
wasi-libcwith-goptions and possibly without-O2options as well. I've found this useful when debugging issues as historically that the build fails when-gis passed or optimizations are removed due to the checks against these expectation files. This commit adds more filters to the list of macros to ensure that optimization/debug related ones are all removed from the expectation lists.