Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark mode color change #55

Closed
wants to merge 5 commits into from
Closed

dark mode color change #55

wants to merge 5 commits into from

Conversation

s5566
Copy link

@s5566 s5566 commented Jul 11, 2021

image
Changes in the logo color
image
anchor tag color change

This PR fixes #40

@Binu42
Copy link
Member

Binu42 commented Jul 11, 2021

@s5566, please don't change the icon color in this PR. you can create separate PR for that, and don't choose white color for the anchor tag.

@s5566
Copy link
Author

s5566 commented Jul 11, 2021

Okay, should I raise an issue for the logo?
I've changed the Facebook logo to white in dark mode and you portfolio link to blue -> white. Should I make it blue -> #21bf73 (sun color)

@Binu42
Copy link
Member

Binu42 commented Jul 11, 2021

sure, go ahead

@Binu42
Copy link
Member

Binu42 commented Jul 11, 2021

@s5566 please keep this PR specific for issue #40. don't change the icon color in this PR. Thanks

@s5566
Copy link
Author

s5566 commented Jul 11, 2021

@Binu42 Please take a look at this. This is specific to #40 issue, only the anchor tag color in dark mode is changed.

@Binu42
Copy link
Member

Binu42 commented Oct 10, 2021

closing got fixed in #76

@Binu42 Binu42 closed this Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors mismatch in dark mode
2 participants