Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide the left sidebar at 76em #39

Open
lapcat opened this issue May 5, 2023 · 3 comments
Open

Don't hide the left sidebar at 76em #39

lapcat opened this issue May 5, 2023 · 3 comments

Comments

@lapcat
Copy link

lapcat commented May 5, 2023

The left sidebar is hidden at around 76em. This is a relatively large window width even on desktop. Compare my two screenshots.

Screen Shot 2023-05-05 at 1 58 15 PM

Screen Shot 2023-05-05 at 1 58 24 PM

@stwrt
Copy link
Member

stwrt commented May 5, 2023

Thanks, I'll need to take look into this. I agree it is a bit over eager with hiding the side bar at large screen sizes.

@stwrt
Copy link
Member

stwrt commented May 17, 2023

So I spent some time looking over this. This behavior is coming from the framework and I would need to do some investigation about modifying this, and I am not completely sure what we would want to set it to at the moment if we did modify it.

Just for some context though other major documentation frameworks I looked at start to exhibit similar collapsing behavior between 1000-1280 pixels. MkDocs Material starts collapsing the side bar at 1220 pixels. This is a little on the higher side, but not abnormal.

Framework px Collapse Sidebar
Docusaurus ~1000px
Apple Developer Docs ~1000px
React Docs ~1024px
MkDocs Material 1220 px
Nextra 1280px
GitHub Docs 1280px

Numbers not super scientific just looked at the px count in WebInspector

@lapcat
Copy link
Author

lapcat commented May 17, 2023

Perhaps the problem is really the dueling document outlines on the left and right sides, which is also kind of confusing.

The Apple developer docs only have an outline on the left side, and even when the outline is collapsed, the widget in the upper left corner can open it.

Screen Shot 2023-05-17 at 6 18 36 AM Screen Shot 2023-05-17 at 6 19 00 AM Screen Shot 2023-05-17 at 6 19 06 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants