Update prettier, change print width to 120, and enable dangling commas for functions #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point, I'd rather not take a huge PR like this into the repo right before the release even if it should not have any real impact on performance in theory. |
|
Adding v3.1 label to match the label on #370 |
fully agreed, this was definitely meant for after the release. Thanks for adding the label. |
julienw
force-pushed
the
change-print-width
branch
from
5c1e296
to
ec73337
Compare
julienw
force-pushed
the
change-print-width
branch
from
ec73337
to
231c0d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
I didn't regenerate all workloads (yet). Please do not land this just yet, this PR is here so that we can decide about #370.
I made separate commits so that we can easily see the effect of each action: