This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
/
ChangeLog-2018-01-01
22473 lines (13871 loc) · 764 KB
/
ChangeLog-2018-01-01
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2017-12-28 Fujii Hironori <Hironori.Fujii@sony.com>
[Win][CMake] Use add_custom_command to copy each forwarding header files
https://bugs.webkit.org/show_bug.cgi?id=180921
Reviewed by Brent Fulgham.
Modifying WTF header files didn't trigger the recompilation of
TestWTF because Ninja doesn't know which command generates the
forwarding header.
Use add_custom_command to copy each forwarding header files.
* Source/cmake/WebKitMacros.cmake: Added a new function WEBKIT_MAKE_FORWARDING_HEADERS.
2017-12-22 Michael Catanzaro <mcatanzaro@igalia.com>
[GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
https://bugs.webkit.org/show_bug.cgi?id=179914
Reviewed by Carlos Garcia Campos.
Let's build JSC as a static library, and link that static lib to *both* our shared
libjavascriptcoregtk and libwebkit2gtk. Then we can fix this and also filter out all the
private symbols that we're currently exposing in libjavascriptcoregtk, which wouldn't be
possible otherwise. The cost of this is disk space. I think this trade-off is reasonable,
because it's the best way I could think of that accomplishes all our goals: (a) install two
shared libs, (b) export only public API symbols, (c) does not require any linker hacks.
Additionally, build with -fvisibility=hidden so that the compiler knows that many symbols
will be stripped out. This should improve code generation. It's actually how WPE was
previously compiled, but I removed this when I added the version script for WPE, because I
thought it was redundant with the version script. It is not, and we should use both,
according to Ulrich Drepper's "How to Write Shared Libraries." We will use
-fvisibility=hidden on all ports; this should be fine, as long as export macros are used
where needed. This is actually a totally separate change, but it makes sense to do it now if
we consider this bug a catch-all "fix how we link WebKit" issue.
* CMakeLists.txt: Rejigger the default library types, and remove the SHARED_CORE option,
which is not likely to work properly in ports that are not expecting it. These changes are
only mildly-related and certainly not required, but it makes sense to clean them up now.
* Source/cmake/OptionsGTK.cmake: Don't set the version script here.
* Source/cmake/OptionsJSCOnly.cmake: Adjust to changes in default library types.
* Source/cmake/OptionsMac.cmake: Adjust to changes in default library types. Override the
library type variables only when required.
* Source/cmake/OptionsWPE.cmake: Overriding the library type variables is no longer
required. Also, don't set the version script here.
* Source/cmake/OptionsWin.cmake: Adjust to changes in default library types. Override the
library type variables only when required.
* Source/cmake/WebKitCompilerFlags.cmake: Build with -fvisibility=hidden,
-fvisibility-inlines-hidden, and -Wno-attributes.
* Source/cmake/wpesymbols.filter: Removed.
2017-12-20 Don Olmstead <don.olmstead@sony.com>
[CMake][Win] Add a way to set CMAKE_IGNORE_PATH
https://bugs.webkit.org/show_bug.cgi?id=181056
Reviewed by Konstantin Tokarev.
* Source/cmake/OptionsWin.cmake:
2017-12-20 Daniel Bates <dabates@apple.com>
Remove Alternative Presentation Button
https://bugs.webkit.org/show_bug.cgi?id=180500
<rdar://problem/35891047>
Reviewed by Simon Fraser.
We no longer need the alternative presentation button.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-12-20 Fujii Hironori <Hironori.Fujii@sony.com>
[CMake][WTF] Lowercase ForwardingHeaders directory name of WTF
https://bugs.webkit.org/show_bug.cgi?id=181022
Reviewed by Konstantin Tokarev.
ForwardingHeaders of WTF are included as <wtf/FooBar.h>. But, the
directory name was uppercase DerivedSources/ForwardingHeaders/WTF.
This confuses Ninja dependency tracking. It should be lowercase.
* Source/cmake/WebKitMacros.cmake: Renamed ForwardingHeaders directory name WTF to wtf.
2017-12-16 Basuke Suzuki <Basuke.Suzuki@sony.com>
[WinCairo] Move the destination of WinCairoRequirements.zip into WebKitLibraries and register it and related files as git ignore files.
https://bugs.webkit.org/show_bug.cgi?id=180875
Reviewed by Alex Christensen.
Add files extracted from WinCairoRequirements.zip
* .gitignore:
2017-12-14 Tomas Popela <tpopela@redhat.com>
Build should fail early is needed Perl modules are not installed
https://bugs.webkit.org/show_bug.cgi?id=180137
Reviewed by Michael Catanzaro.
Don't finish the configure successfully if the required Perl modules
are not installed. Start to require modules that are needed for
WPE/GTK+ ports.
* Source/cmake/FindPerlModules.cmake: Copied from
https://github.com/KDE/kdelibs4support/blob/master/cmake/FindPerlModules.cmake
and made it WebKit style compliant.
* Source/cmake/WebKitCommon.cmake:
2017-12-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
[WPE] WebCrypto should be a public option.
https://bugs.webkit.org/show_bug.cgi?id=180780
Reviewed by Konstantin Tokarev.
Make ENABLE_WEB_CRYPTO public and lower the dependency requirements
when this option is not enabled. This is also how the GTK+ port
configures the visibility of this option and its dependencies.
* Source/cmake/OptionsWPE.cmake:
2017-12-13 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.
2017-12-12 Don Olmstead <don.olmstead@sony.com>
[WinCairo] Enable WebP support
https://bugs.webkit.org/show_bug.cgi?id=179908
Reviewed by Konstantin Tokarev.
* Source/cmake/OptionsWinCairo.cmake:
2017-12-08 Fujii Hironori <Hironori.Fujii@sony.com>
[WinCairo][Ninja] Incremental build failure of WTF
https://bugs.webkit.org/show_bug.cgi?id=180521
Reviewed by Konstantin Tokarev.
WTF included its forwarding headers in Windows ports. The
directory DerivedSources/ForwardingHeaders shouldn't be a include
path for WTF.
* Source/cmake/OptionsWin.cmake:
Removed DerivedSources/ForwardingHeaders and DerivedSources from include paths.
2017-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
[WPE][GTK] Freeze WebKit version in user agent
https://bugs.webkit.org/show_bug.cgi?id=180475
Reviewed by Carlos Garcia Campos.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2017-12-05 Stephan Szabo <stephan.szabo@sony.com>
Switch windows build to Visual Studio 2017
https://bugs.webkit.org/show_bug.cgi?id=172412
Reviewed by Per Arne Vollan.
* Source/cmake/OptionsMSVC.cmake:
2017-12-01 Konstantin Tokarev <annulen@yandex.ru>
[cmake] Make description of ENABLE_DRAG_SUPPORT more informative
https://bugs.webkit.org/show_bug.cgi?id=180266
Reviewed by Michael Catanzaro.
When disabled, it also disables selection of text with dragging, and this
comes as a surprise for many people.
* Source/cmake/WebKitFeatures.cmake:
2017-12-01 Michael Catanzaro <mcatanzaro@igalia.com>
[GStreamer] Fix USE_GSTREAMER_GL check for GStreamer 1.10
https://bugs.webkit.org/show_bug.cgi?id=180256
Reviewed by Carlos Alberto Lopez Perez.
It's not safe to change the value of build options after WEBKIT_OPTION_END, since it breaks
the option dependency checker. I don't think that actually hurts anything in this case, but
let's not encourage bad practice. Also, it's not good for features to be secretly disabled.
Nobody reads CMake output unless there is a fatal error. Failing the build at the CMake
stage lets distributors know that a feature will be missing. And of course, it's still
possible to disable USE_GSTREAMER_GL to avoid the increased GStreamer requirement.
* Source/cmake/GStreamerChecks.cmake:
2017-12-01 Michael Catanzaro <mcatanzaro@igalia.com>
[GTK] [MSE] Turn MSE on by default
https://bugs.webkit.org/show_bug.cgi?id=167107
Reviewed by Carlos Alberto Lopez Perez.
Turn on the ENABLE_MEDIA_SOURCE build option. Fail the build if GStreamer 1.8 is not
installed and ENABLE_MEDIA_SOURCE has not been disabled.
* Source/cmake/GStreamerChecks.cmake:
* Source/cmake/GStreamerDefinitions.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2017-11-30 Stephan Szabo <stephan.szabo@sony.com>
Make LegacyCustomProtocolManager optional for network process
https://bugs.webkit.org/show_bug.cgi?id=176230
Reviewed by Alex Christensen.
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-11-29 Alex Christensen <achristensen@webkit.org>
Fix Mac CMake build.
* Source/cmake/OptionsMac.cmake:
2017-11-28 Michael Catanzaro <mcatanzaro@igalia.com>
REGRESSION(r225098): [WPE] Some features have changed of value (70 new failures)
https://bugs.webkit.org/show_bug.cgi?id=180004
Reviewed by Alex Christensen.
Turn on ENABLE_ENCRYPTED_MEDIA and ENABLE_WEBGL2 when building with
ENABLE_EXPERIMENTAL_FEATURES. Also, let's stop turning off ENABLE_USERSELECT_ALL, as I doubt
there's any good reason for that.
* Source/cmake/OptionsWPE.cmake:
2017-11-27 Don Olmstead <don.olmstead@sony.com>
[CMake][Win] Conditionally select DLL CRT or static CRT
https://bugs.webkit.org/show_bug.cgi?id=170594
Reviewed by Alex Christensen.
* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsMSVC.cmake:
2017-11-27 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Values of CMAKE_BUILD_TYPE from toolchain file are ignored
https://bugs.webkit.org/show_bug.cgi?id=179971
Reviewed by Carlos Alberto Lopez Perez.
* CMakeLists.txt: Call project() first, as it loads the toolchain
file, so that's done before checking CMAKE_BUILD_TYPE.
2017-11-22 Michael Catanzaro <mcatanzaro@igalia.com>
Sanity-check feature defaults in WebKitFeatures.cmake
https://bugs.webkit.org/show_bug.cgi?id=179095
Reviewed by Konstantin Tokarev.
Change the default value of some features in WebKitFeatures.cmake to reduce the number of
Options*.cmake files the feature's default value must be overridden in.
Remove feature definitions where they are redundant with the definition in
WebKitFeatures.cmake, particluarly in OptionsMac.cmake.
This commit should not include any functional changes. It just aims to reduce the total
number of times we need to call WEBKIT_OPTION_DEFAULT_PORT_VALUE.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-11-22 Tim Horton <timothy_horton@apple.com> and Michael Catanzaro <mcatanzaro@igalia.com>
Remove build-webkit's notion of feature flags having a default value
https://bugs.webkit.org/show_bug.cgi?id=177338
Reviewed by Carlos Alberto Lopez Perez.
Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-11-21 Zan Dobersek <zdobersek@igalia.com>
Drop ENABLE_IMAGE_DECODER_DOWN_SAMPLING code
https://bugs.webkit.org/show_bug.cgi?id=179921
Reviewed by Carlos Garcia Campos.
* Source/cmake/WebKitFeatures.cmake: Remove the CMake option that
enabled IMAGE_DECODER_DOWN_SAMPLING code.
2017-11-20 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.2 release.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.
2017-11-20 Michael Catanzaro <mcatanzaro@igalia.com>
Remove ENABLE_ALLINONE_BUILD option
https://bugs.webkit.org/show_bug.cgi?id=179823
Reviewed by Darin Adler.
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-11-19 Tim Horton <timothy_horton@apple.com>
Remove unused TOUCH_ICON_LOADING feature flag
https://bugs.webkit.org/show_bug.cgi?id=179873
Reviewed by Simon Fraser.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-11-19 Yusuke Suzuki <utatane.tea@gmail.com>
Add CPU(UNKNOWN) to cover all the unknown CPU types
https://bugs.webkit.org/show_bug.cgi?id=179243
Reviewed by JF Bastien.
Drop SH4, S390, and S390X explicit support. They are handled as CPU(UNKNOWN).
* CMakeLists.txt:
2017-11-19 Tim Horton <timothy_horton@apple.com>
Remove unused LEGACY_VENDOR_PREFIXES feature flag
https://bugs.webkit.org/show_bug.cgi?id=179872
Reviewed by Darin Adler.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-11-16 Don Olmstead <don.olmstead@sony.com>
[WinCairo] Update WinCairoRequirements
https://bugs.webkit.org/show_bug.cgi?id=179790
Reviewed by Alex Christensen.
* Source/cmake/OptionsWinCairo.cmake:
2017-11-16 Daniel Bates <dabates@apple.com>
Add feature define for alternative presentation button element
https://bugs.webkit.org/show_bug.cgi?id=179692
Part of <rdar://problem/34917108>
Reviewed by Andy Estes.
Only enabled on Cocoa platforms by default.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-11-16 Michael Catanzaro <mcatanzaro@igalia.com>
[WPE] Expose ENABLE_JIT and USE_SYSTEM_MALLOC options
https://bugs.webkit.org/show_bug.cgi?id=179730
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/OptionsWPE.cmake:
2017-11-15 Carlos Garcia Campos <cgarcia@igalia.com>
[WPE] Add initial support for WebDriver
https://bugs.webkit.org/show_bug.cgi?id=179727
Reviewed by Michael Catanzaro.
Enable WebDriver by default in WPE.
* Source/cmake/OptionsWPE.cmake:
2017-11-15 Keith Miller <keith_miller@apple.com>
Unreviewed, sort async iteration feature.
* Source/cmake/WebKitFeatures.cmake:
2017-11-15 Keith Miller <keith_miller@apple.com>
REGRESSION(r224787): [Linux] Introduced 144 GTK/WPE JS test failures
https://bugs.webkit.org/show_bug.cgi?id=179704
Reviewed by Yusuke Suzuki.
Add feature flag for Async iteration.
* Source/cmake/WebKitFeatures.cmake:
2017-11-13 Michael Catanzaro <mcatanzaro@igalia.com>
[GTK] Require woff2 1.0.2 and drop direct brotli dependency
https://bugs.webkit.org/show_bug.cgi?id=179630
Reviewed by Frédéric Wang.
* Source/cmake/FindBrotliDec.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:
2017-11-09 Michael Catanzaro <mcatanzaro@igalia.com>
[WPE] Use linker script to control exported symbols
https://bugs.webkit.org/show_bug.cgi?id=179358
Reviewed by Carlos Alberto Lopez Perez.
The C API is being inadvertently exported because it's marked as WEBKIT_EXPORT in the header
files. But of course it should only be exported in DEVELOPER_MODE, where it's needed for
WebKitTestRunner. Use (almost) the same linker version script as GTK to fix this. It's
slightly different because WPE does not have WebKitPluginProcess.
This also reduces binary size of libWPEWebKit.so in debug mode from 615 MB down to 497 MB.
(Haven't checked release mode.)
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/wpesymbols.filter: Added.
2017-11-08 Michael Catanzaro <mcatanzaro@igalia.com>
[WPE] Turn on ENABLE_INDEXED_DATABASE_IN_WORKERS
https://bugs.webkit.org/show_bug.cgi?id=179094
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/OptionsWPE.cmake:
2017-11-07 Michael Catanzaro <mcatanzaro@igalia.com>
[WPE] Turn on ENABLE_MEDIA_SOURCE
https://bugs.webkit.org/show_bug.cgi?id=179093
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/OptionsWPE.cmake:
2017-11-06 Michael Catanzaro <mcatanzaro@igalia.com>
Unreviewed, fix WPE build after r224492
https://bugs.webkit.org/show_bug.cgi?id=179009
* Source/cmake/OptionsWPE.cmake:
2017-11-06 Michael Catanzaro <mcatanzaro@igalia.com>
[WPE] Clean up OptionsWPE.cmake
https://bugs.webkit.org/show_bug.cgi?id=179009
Reviewed by Žan Doberšek.
* Source/cmake/OptionsWPE.cmake:
2017-11-06 Michael Catanzaro <mcatanzaro@igalia.com>
[WPE][GTK] Always use SET_AND_EXPOSE_TO_BUILD to set build variables
https://bugs.webkit.org/show_bug.cgi?id=179038
Reviewed by Žan Doberšek.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2017-11-03 Michael Catanzaro <mcatanzaro@igalia.com>
[WPE][GTK] Avoid duplicating code for dist and distcheck targets
https://bugs.webkit.org/show_bug.cgi?id=179154
Reviewed by Carlos Garcia Campos.
This commit just reduces some CMake code duplication between GTK and WPE.
* Source/PlatformGTK.cmake:
* Source/PlatformWPE.cmake:
* Source/cmake/WebKitDist.cmake: Added.
2017-11-02 Tim Horton <timothy_horton@apple.com>
Reduce duplication in the toplevel Makefile
https://bugs.webkit.org/show_bug.cgi?id=179204
Unreviewed build fix.
* Source/Makefile:
Take three. An empty SDKROOT should be like Mac (and build all the things).
2017-11-02 Tim Horton <timothy_horton@apple.com>
Reduce duplication in the toplevel Makefile
https://bugs.webkit.org/show_bug.cgi?id=179204
* Source/Makefile:
Address some post-landing review comments to keep the order of the MODULES correct.
2017-11-02 Tim Horton <timothy_horton@apple.com>
Reduce duplication in the toplevel Makefile
https://bugs.webkit.org/show_bug.cgi?id=179204
Reviewed by Simon Fraser.
* Source/Makefile:
Make MODULES additive instead of completely repeated, and only build
libwebrtc where it's needed.
2017-11-02 Alberto Garcia <berto@igalia.com>
Unreviewed, fix typos in library names for the GTK+ port.
* Source/cmake/OptionsGTK.cmake:
2017-10-31 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.1 release.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.
2017-10-31 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix GTK+/WPE make distcheck.
* CMakeLists.txt: Only include PerformanceTests directory to the build for GTK+ and WPE ports when developer
mode is enabled.
2017-10-26 Adrian Perez de Castro <aperez@igalia.com>
[WPE] Use proper shared object versioning for libWPEWebKit.so
https://bugs.webkit.org/show_bug.cgi?id=178878
Reviewed by Michael Catanzaro.
Move the CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE() to a new CMake include file,
and use it both for the GTK+ and WPE ports. Also add a SET_PROJECT_VERSION() macro to
unify setting the PROJECT_VERSION* family of variables.
* Source/cmake/OptionsGTK.cmake: Use the common macros imported from VersioningUtils.cmake.
* Source/cmake/OptionsWPE.cmake: Properly assign a shared object version to libWPEWebKit.so,
using the common macros from VersioningUtils.cmake.
* Source/cmake/VersioningUtils.cmake: Added.
2017-10-26 Adrian Perez de Castro <aperez@igalia.com>
[GTK] WebKit library .so version is not being set correctly
https://bugs.webkit.org/show_bug.cgi?id=178873
Reviewed by Michael Catanzaro.
* Source/cmake/OptionsGTK.cmake: Adjust name of the target for which the .so version gets calculated.
2017-10-24 Stephan Szabo <stephan.szabo@sony.com>
[Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests
https://bugs.webkit.org/show_bug.cgi?id=177279
Reviewed by Yusuke Suzuki.
* Source/cmake/OptionsJSCOnly.cmake:
2017-10-21 Tim Horton <timothy_horton@apple.com>
Turn on ccache for Mac cmake builds by default
https://bugs.webkit.org/show_bug.cgi?id=177059
Reviewed by Sam Weinig.
* Source/cmake/WebKitCCache.cmake: Added.
* Source/cmake/WebKitCommon.cmake:
Turn on ccache for Mac CMake builds (Makefile and Ninja generators only)
if it's installed, making use of CMake's ability to wrap the compiler invocation.
2017-10-20 Antoine Quint <graouts@apple.com>
[Web Animations] Provide basic timeline and animation interfaces
https://bugs.webkit.org/show_bug.cgi?id=178526
Reviewed by Dean Jackson.
Remove the WEB_ANIMATIONS compile-time flag.
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-10-18 Keith Miller <keith_miller@apple.com>
Setup WebCore build to start using unified sources.
https://bugs.webkit.org/show_bug.cgi?id=178362
Reviewed by Tim Horton.
Pass features to the unified source bundler script.
* Source/cmake/WebKitCommon.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/WebKitMacros.cmake:
2017-10-18 Zan Dobersek <zdobersek@igalia.com>
Remove remnants of OpenWebRTC
https://bugs.webkit.org/show_bug.cgi?id=178437
Reviewed by Alejandro G. Castro.
Remove the FindOpenWebRTC.cmake file and the searches for it in both
OptionsGTK and OptionsWPE.
* Source/cmake/FindOpenWebRTC.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2017-10-10 Adrian Perez de Castro <aperez@igalia.com>
[WPE] Remove the possibility of installing the old WebKit2 C API
https://bugs.webkit.org/show_bug.cgi?id=178125
Reviewed by Michael Catanzaro.
* Source/cmake/OptionsWPE.cmake: Remove definition of the EXPORT_DEPRECATED_WEBKIT2_C_API
build option.
2017-10-10 Michael Catanzaro <mcatanzaro@igalia.com>
[WPE] Expose ENABLE_XSLT option
https://bugs.webkit.org/show_bug.cgi?id=177857
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/OptionsWPE.cmake:
2017-10-09 Adrian Perez de Castro <aperez@igalia.com>
[WPE][GTK] Propagate libepoxy compiler flags obtained from pkg-config
https://bugs.webkit.org/show_bug.cgi?id=178081
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/FindLibEpoxy.cmake: Define the ${LIBEPOXY_DEFINITIONS} variable when libepoxy
is found by pkg-config. This contains the value of the "Cflags" field from "epoxy.pc".
2017-10-05 Frederic Wang <fwang@igalia.com>
Remove WOFF2 from Source/ThirdParty.
https://bugs.webkit.org/show_bug.cgi?id=177862
Reviewed by Michael Catanzaro.
* Source/CMakeLists.txt: Do not build the woff2 source.
* Source/cmake/FindWOFF2Dec.cmake: Added. New cmake module for woff2.
* Source/cmake/OptionsGTK.cmake: Load the woff2 package.
2017-10-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
Generate a compile error if release is built without compiler optimizations
https://bugs.webkit.org/show_bug.cgi?id=177665
Reviewed by Brian Burg.
Default to RelWithDebInfo if CMAKE_BUILD_TYPE is unset.
* CMakeLists.txt:
2017-10-05 Tim Horton <timothy_horton@apple.com>
Make progress toward properly-formed XPC services in the Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=177918
Reviewed by Alex Christensen.
* Source/cmake/WebKitMacros.cmake:
Add a macro wrapper around 'ln'.
2017-10-03 Frederic Wang <fwang@igalia.com>
Remove Brotli from Source/ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=177804
Reviewed by Michael Catanzaro.
* Source/CMakeLists.txt: Do not build ThirdParty/brotli anymore.
* Source/cmake/FindBrotliDec.cmake: Added. New cmake module to find Brotli via PkgConfig.
* Source/cmake/OptionsGTK.cmake: Expose USE_WOFF2 as a public option and use find_package
to look for brotli.
2017-10-05 Yusuke Suzuki <utatane.tea@gmail.com>
[Linux] Port MallocBench
https://bugs.webkit.org/show_bug.cgi?id=177856
Reviewed by Filip Pizlo.
* CMakeLists.txt:
2017-10-04 Ryan Haddad <ryanhaddad@apple.com>
Unreviewed, rolling out r222840.
This change breaks internal builds.
Reverted changeset:
"Generate a compile error if release is built without compiler
optimizations"
https://bugs.webkit.org/show_bug.cgi?id=177665
http://trac.webkit.org/changeset/222840
2017-10-04 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r222775.
https://bugs.webkit.org/show_bug.cgi?id=177890
Significantly increased the WebKit build time (Requested by
rniwa on #webkit).
Reverted changeset:
"Build libwebrtc unit tests executables"
https://bugs.webkit.org/show_bug.cgi?id=177211
http://trac.webkit.org/changeset/222775
2017-10-04 Miguel Gomez <magomez@igalia.com>
Add animation support for WebP images
https://bugs.webkit.org/show_bug.cgi?id=113124
Reviewed by Žan Doberšek.
* Source/cmake/FindWebP.cmake:
2017-10-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
Generate a compile error if release is built without compiler optimizations
https://bugs.webkit.org/show_bug.cgi?id=177665
Reviewed by Michael Catanzaro.
Default to RelWithDebInfo if CMAKE_BUILD_TYPE is unset.
* CMakeLists.txt:
2017-10-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GLib] Let WebCore know of low power situations
https://bugs.webkit.org/show_bug.cgi?id=177810
Reviewed by Carlos Garcia Campos.
WebCore can use knowledge of low power situations to throttle timers and avoid expensive
checks, lowering power usage. We can use upower's warning level to let WebCore know we are
in such a situation.
* Source/cmake/OptionsGTK.cmake: depend on upower-glib.
* Source/cmake/FindUPowerGLib.cmake: Added.
2017-10-03 Youenn Fablet <youenn@apple.com>
Build libwebrtc unit tests executables
https://bugs.webkit.org/show_bug.cgi?id=177211
Reviewed by Alex Christensen.
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
2017-10-02 Olivier Blin <olivier.blin@softathome.com>
[WPE] Remove GnuTLS dependency
https://bugs.webkit.org/show_bug.cgi?id=177750
Reviewed by Michael Catanzaro.
libgcrypt is used by default instead of GnuTLS.
See bug 163125
* Source/cmake/OptionsWPE.cmake:
2017-10-02 Olivier Blin <olivier.blin@softathome.com>
[WPE] Do not require XSLT if disabled
https://bugs.webkit.org/show_bug.cgi?id=177752
Reviewed by Michael Catanzaro.
* Source/cmake/OptionsWPE.cmake: libxslt is not a hard dep
2017-10-02 Michael Catanzaro <mcatanzaro@igalia.com>
Remove ENABLE_CSS_REGIONS
https://bugs.webkit.org/show_bug.cgi?id=177689
Reviewed by Darin Adler.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-09-29 Matt Lewis <jlewis3@apple.com>
Unreviewed, rolling out r222652.
This broke an internal build.
Reverted changeset:
"Build libwebrtc unit tests executables"
https://bugs.webkit.org/show_bug.cgi?id=177211
http://trac.webkit.org/changeset/222652
2017-09-29 Youenn Fablet <youenn@apple.com>
Build libwebrtc unit tests executables
https://bugs.webkit.org/show_bug.cgi?id=177211
Reviewed by Alex Christensen.
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
2017-09-27 Ryan Haddad <ryanhaddad@apple.com>
Unreviewed, rolling out r222537.
This change broke internal builds.
Reverted changeset:
"Build libwebrtc unit tests executables"
https://bugs.webkit.org/show_bug.cgi?id=177211
http://trac.webkit.org/changeset/222537
2017-09-26 Youenn Fablet <youenn@apple.com>
Build libwebrtc unit tests executables
https://bugs.webkit.org/show_bug.cgi?id=177211
Reviewed by Alex Christensen.
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
2017-09-26 Keith Miller <keith_miller@apple.com>
CMake should reconfigure if the Sources.txt files are touched
https://bugs.webkit.org/show_bug.cgi?id=177508
Reviewed by JF Bastien.
* Source/cmake/WebKitMacros.cmake:
2017-09-24 Keith Miller <keith_miller@apple.com>
JSC build should use unified sources for derived sources
https://bugs.webkit.org/show_bug.cgi?id=177421
Reviewed by JF Bastien.
* Source/cmake/WebKitMacros.cmake:
2017-09-26 Zan Dobersek <zdobersek@igalia.com>
[CMake] Use implicit include directories for Clang as well
https://bugs.webkit.org/show_bug.cgi?id=177426
Reviewed by Michael Catanzaro.
In WebKitCompilerFlags.cmake, also gather and use the system
include directories for C and C++ build targets when compiling
with Clang. This fixes compilation errors when cross-building
WebKit with a Clang-based toolchain.
COMPILER_IS_GCC_OR_CLANG is used to check for GCC or Clang
compilers. That only checks for the C++ compiler, but it's not
reasonable to expect two widely different compilers being used
for C and C++ compilation.
* Source/cmake/WebKitCompilerFlags.cmake:
2017-09-25 Timothy Horton <timothy_horton@apple.com>
Make progress on getting Mac CMake building again
https://bugs.webkit.org/show_bug.cgi?id=177443
Unreviewed, just "fixing" the build.
* Source/cmake/OptionsMac.cmake:
Turn on WEB_CRYPTO on Mac. We need to do a bigger cleanup of feature
defines, but this one is important because we have SUBTLE_CRYPTO on
and there is some amount of interdependency.
2017-09-22 Per Arne Vollan <pvollan@apple.com>
[Win] WebKit is built as a static library, and not as a dll.
https://bugs.webkit.org/show_bug.cgi?id=177365
Reviewed by Brent Fulgham.
Set target type for WebKitLegacy target.
* Source/cmake/OptionsWin.cmake:
2017-09-22 Matt Lewis <jlewis3@apple.com>
Unreviewed, rolling out r222394.
This broke the Windows Debug Build.
Reverted changeset:
"Remove build-webkit's notion of feature flags having a
default value"
https://bugs.webkit.org/show_bug.cgi?id=177338
http://trac.webkit.org/changeset/222394
2017-09-22 Tim Horton <timothy_horton@apple.com> and Michael Catanzaro <mcatanzaro@igalia.com>
Remove build-webkit's notion of feature flags having a default value
https://bugs.webkit.org/show_bug.cgi?id=177338
Reviewed by Alex Christensen.
Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-09-20 Keith Miller <keith_miller@apple.com>
JSC should use unified sources for platform specific files.
https://bugs.webkit.org/show_bug.cgi?id=177290
Reviewed by Michael Saboff.
Change WEBKIT_COMPUTE_SOURCES CMake macro to look for platform
specific unified source lists. This is done in the same way that
we look for port specific configuration files. For example, if I
were building for the Mac port WEBKIT_COMPUTE_SOURCES would add
the Sources.txt and SourcesMac.txt source lists to the list of
unified sources.
* Source/cmake/WebKitMacros.cmake:
2017-09-20 Keith Miller <keith_miller@apple.com>
JSC Xcode build should use unified sources for platform independent files
https://bugs.webkit.org/show_bug.cgi?id=177190
Reviewed by Saam Barati.
Add a macro for collecting the set of "header" source files and adding the bundle
files to the "sources" list.
* Source/cmake/WebKitMacros.cmake:
2017-09-20 Michael Catanzaro <mcatanzaro@igalia.com>
REGRESSION(r222194) [WPE] Library and executable output names broken
https://bugs.webkit.org/show_bug.cgi?id=177273
Reviewed by Carlos Alberto Lopez Perez.
Move the WebKit2 output name variables from here to Source/WebKit.
* Source/cmake/OptionsWPE.cmake:
2017-09-20 Alberto Garcia <berto@igalia.com>