Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are Python boolean traps worth fixing? #49

Open
cclauss opened this issue Apr 29, 2023 · 1 comment
Open

Are Python boolean traps worth fixing? #49

cclauss opened this issue Apr 29, 2023 · 1 comment

Comments

@cclauss
Copy link
Contributor

cclauss commented Apr 29, 2023

% ruff --select=FBT --statistics .

93	FBT003	Boolean positional value in function call
12	FBT002	Boolean default value in function definition

My sense is that it breaks too much to fix them now but it is an interesting insight.

@Cito
Copy link
Member

Cito commented Apr 29, 2023

The main problem here is that DBUtils does not support keyword-only parameters for the constructors of its classes.

This should be changed, but probably only in the next major version since this would break backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants