Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PZN8 support still in planning? #167

Open
Richnator opened this issue Aug 17, 2022 · 3 comments · May be fixed by #188
Open

PZN8 support still in planning? #167

Richnator opened this issue Aug 17, 2022 · 3 comments · May be fixed by #188
Labels
contributions welcome Further design discussions and PRs are welcome. enhancement

Comments

@Richnator
Copy link

Hello,

I was wondering if PZN8 support is still in the planning. In codex.py (line 115-118) a comment states that the support was already planned for release with v0.9. Is this still in progress or am I missing something?

class PZN8(PZN7):
"""Will be fully added in v0.9."""
digits = 7

https://github.com/WhyNotHugo/python-barcode/blob/main/barcode/codex.py#:~:text=class%20PZN8(,digits%20%3D%207
@WhyNotHugo
Copy link
Owner

It's not implemented. PRs welcome.

@WhyNotHugo WhyNotHugo added enhancement contributions welcome Further design discussions and PRs are welcome. labels Sep 15, 2022
@fostermaier
Copy link
Contributor

Requires some tweaking regarding checksum and code length, but shouldn't be too hard to implement. I'm attaching a preliminary test against https://www.softmatic.com/de/barcode-code-pzn.html below. Will submit a PR when it's ready.

Screenshot_20221126_002131

@fostermaier
Copy link
Contributor

PZN8 feature is ready in here
https://github.com/fostermaier/python-barcode/commits/pzn8
I'll open a PR once the pending PR is closed so that I don't need to rebase.

@fostermaier fostermaier linked a pull request Dec 1, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions welcome Further design discussions and PRs are welcome. enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement PZN8 fostermaier/python-barcode
3 participants
@WhyNotHugo @fostermaier @Richnator