Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Fight Selection Panel/ Boss Percentage #6266

Open
riyuk opened this issue Jul 27, 2023 · 2 comments
Open

[UI] Fight Selection Panel/ Boss Percentage #6266

riyuk opened this issue Jul 27, 2023 · 2 comments

Comments

@riyuk
Copy link

riyuk commented Jul 27, 2023

Currently if you wipe on a Boss with 0,X% Life left the HP Progress-Bar is filled up completly.

image

Wouldn't it be better if the percentaged get floored by Math.floor?
So there still would be a gap visible - currently you can't tell why this bar is orange instead of green since it's completly full.

https://github.com/WoWAnalyzer/WoWAnalyzer/blob/940a0e1ed0970f5d5732c729b6b904d94cad73e1/src/interface/report/FightSelectionPanelList.tsx#L94C85-L94C85

@abelito75
Copy link
Contributor

To me if the bar is orange, is labeled a wipe but completely full
I'd assume that we just wiped at an ultra low %

But maybe thats a bad assumption

@riyuk
Copy link
Author

riyuk commented Jul 28, 2023

The Question might be still the same.
With Boss HP at >99,0% it would be good to actually see a orange Bar at all.
With Boss HP at <1,0% a visible gap would be nice to see.

Currently if you just work with decimals there would be half-pixels in the calculation which obviously cannot be displayed.
-> And we got the "issue" - which is a issue in my oppinion - which occurs in the described two cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants