Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit theme slug renaming to just slugs #569

Open
pbking opened this issue Apr 18, 2024 · 1 comment
Open

Limit theme slug renaming to just slugs #569

pbking opened this issue Apr 18, 2024 · 1 comment

Comments

@pbking
Copy link
Contributor

pbking commented Apr 18, 2024

When exporting the theme without applying translations or asset localization, the name of existing theme assets are changed.

  • Clone the theme "Adventurer"
  • Note that one of the assets used has the string "adventurer" in it. The reference to that asset in the patterns is changed to the NEW slug, though the file is not changed.
@pbking
Copy link
Contributor Author

pbking commented Apr 18, 2024

Alternatively, since the issue at hand was that assets used in the theme that have the slug in the filename have been changed, we could consider changing the file to contain the new slug instead.

That feels more like a bandaid, but at least doesn't result in broken image assets for those themes that are effected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant