Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content attribute type array instead of string in 03-editable block examples #220

Open
tloureiro opened this issue May 12, 2022 · 2 comments
Open

Content attribute type array instead of string in 03-editable block examples #220

tloureiro opened this issue May 12, 2022 · 2 comments
Assignees
@tloureiro
Labels
bug

Comments

@tloureiro
Copy link
Contributor

Why the type of content attribute of the 03-editable (and 03-editable-jsx) examples is array and not string? I know they work correctly but wouldn't string be a more appropriate type?

Thanks!
@ryanwelcher
Copy link
Contributor

It looks like the JSX version is using string and the non-JSX version is using array.

We should probably have them both set to string. Interested in putting together a pull request?

@tloureiro tloureiro mentioned this issue Sep 20, 2022
Merged
@tloureiro
Copy link
Contributor Author

Yes, here it is (sorry for the delay) #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tloureiro tloureiro

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanwelcher @tloureiro