Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some items listed in changelog for v15.0.0 of @wordpress/scripts package not in release #31526

Closed
pierlon opened this issue May 6, 2021 · 7 comments · Fixed by #31532
Closed
Assignees
Labels
[Package] Scripts /packages/scripts [Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers

Comments

@pierlon
Copy link
Contributor

pierlon commented May 6, 2021

The following items listed in the changelog for the @wordpress/scripts package are not included in the latest release (at the moment v15.0.1):

(Edit: Last item quoted above is confirmed to be in release)

There might be more but I haven't checked.

Expected behaviour

To see the items listed in the changelog under the 15.0.0 release for @wordpress/scripts to be available.

Actual behaviour

Items listed in changelog not available.

@talldan
Copy link
Contributor

talldan commented May 6, 2021

@pierlon I just checked and it seems fine. I tested by installing the latest version locally in a new project and trying the format command:
Screenshot 2021-05-06 at 2 14 19 pm

I can also verify that jest-circus is installed though I didn't go as far as writing and running some tests.

It sounds to me like your local package might not have updated correctly. It could be worth double-checking the installed version and maybe seeing whether you have any conflicting versions specified elsewhere.

@talldan talldan added [Status] Needs More Info Follow-up required in order to be actionable. [Package] Scripts /packages/scripts labels May 6, 2021
@pierlon
Copy link
Contributor Author

pierlon commented May 6, 2021

@talldan I was mistaken about the format command, but the others still apply. In the @wordpress/scripts@15.0.1 tagged release you can see there is no testRunner set in the jest-unit.config.js file, for example:

const jestUnitConfig = {
preset: '@wordpress/jest-preset-default',
};

While in the trunk branch it is:

const jestUnitConfig = {
testRunner: 'jest-circus/runner',
preset: '@wordpress/jest-preset-default',
reporters: [
'default',
path.join( __dirname, 'jest-github-actions-reporter.js' ),
],
};

Also see this quick Runkit demo demonstrating that a testRunner nor a reporters key is defined in jest-unit.config.js.

@talldan
Copy link
Contributor

talldan commented May 6, 2021

cc @kevin940726 @gziolo.

@gziolo
Copy link
Member

gziolo commented May 6, 2021

The changelog published to npm for 15.0.1 looks good:

https://unpkg.com/browse/@wordpress/scripts@15.0.1/CHANGELOG.md

We might have some sort of merge issue in the trunk branch. I will investigate and update. We need to automate the process of adding entries to the changelog files because it seems to be very unreliable – both in terms of depending on contributors to add entries in the first place and ensuring that backporting commits with changes from the release branch are reliable.

@gziolo
Copy link
Member

gziolo commented May 6, 2021

Opened #31532 that should remove the confusion. I will inspect other packages as well.

@pierlon, the good part is that all those that are listed will be published next week 😄

@gziolo gziolo added [Type] Developer Documentation Documentation for developers and removed [Status] Needs More Info Follow-up required in order to be actionable. labels May 6, 2021
@gziolo gziolo self-assigned this May 6, 2021
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label May 6, 2021
@pierlon
Copy link
Contributor Author

pierlon commented May 6, 2021

Thanks @gziolo!

@gziolo
Copy link
Member

gziolo commented May 6, 2021

Thanks for catching it and reporting back 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Scripts /packages/scripts [Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants