Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Command Palette button on Navigation Focus Mode with Top toolbar #61257

Open
jeryj opened this issue Apr 30, 2024 · 0 comments
Open

Missing Command Palette button on Navigation Focus Mode with Top toolbar #61257

jeryj opened this issue Apr 30, 2024 · 0 comments
Labels
[Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended

Comments

@jeryj
Copy link
Contributor

jeryj commented Apr 30, 2024

Description

When on the navigation focus mode and the top-level navigation is selected, the command palette button is missing. We could add useHasBlockToolbar to check if a toolbar will be rendered or not, but it's a slow check that increases the block selection/focus metric by 25%. Ideally, we could solve this with CSS-only, but it would likely require shuffling the DOM around so the block toolbar is a sibling of edit-site-header-edit-mode__center.

The issue is pretty minor overall and if the navigation focus-mode is going away soon(?) then maybe this isn't worth addressing.

Step-by-step reproduction instructions

  1. Go to site editor
  2. Select Navigation from the sidebar
  3. Select a Navigation Menu
  4. Turn on Top Toolbar
  5. Select the navigation block
  6. Arrow up until the top level navigation block is selected
  7. Command palette and block tools are both missing

Screenshots, screen recording, code snippet

Screen.Recording.2024-04-30.at.12.54.34.PM.mov

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jeryj jeryj added the [Type] Bug An existing feature does not function as intended label Apr 30, 2024
@jordesign jordesign added Needs Testing Needs further testing to be confirmed. [Package] Commands /packages/commands and removed Needs Testing Needs further testing to be confirmed. labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants