Remove Button component from social link block, replace with button element
#61270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
added
[Type] Enhancement
|
Size Change: +357 B (+0.02%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2894d79. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8905885652
|
aaronrobertshaw
approved these changes
May 1, 2024
There was a problem hiding this comment.
Changes LGTM! Thanks for the quick update 🚀
✅ Updates are confined to the editor
✅ Social Links buttons appear the same on trunk and this PR
✅ Switching block styles that impact things like padding are displayed correctly
| Before | After |
|---|---|
 |
 |
 |
 |
I'm glad we only had to replicate a reduced set of the button components styles to achieve the same look. This will definitely help unblock the reduction of specificity for block style variations in #61032.
|
|
||
| // The editor uses the button element, the frontend uses a link. | ||
| // Therefore we unstyle the button element to make it more like the frontend. | ||
| .wp-block-social-link-anchor { |
There was a problem hiding this comment.
Would we be able to lower the specificity here? If we ever want to support border or typography styling for this block, these styles could interfere.
There was a problem hiding this comment.
I was planning to look at dropping the specificity here over in #61032 as the block style variations need it as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #61269
See #61032 (comment) for some background. This PR ties in to the work to improve the block variation styles feature as a means to achieving section styles. That work requires block specificity to be as low as possible, which this change helps with.
The social link block is currently using the
@wordpress/componentsButtoncomponent for its in canvas UI.This PR replaces it with the standard
buttonelement while keeping the same styles.Why?
There are a few reasons why using the
Buttoncomponent isn't a great idea for the editor canvas:components-buttonclass name - this is the reason why a dev note will be needed for this PR.@wordpress/componentscomponents have, whereas for blocks we need to keep the specificity as low as possible so that extenders have a comfortable time implementing styles.@wordpress/componentscomponent are not available in the editor canvas iframe, so this could mean breakage in the future.@wordpress/componentsever changes to a different visual style or has a refactor it could break the blockHow?
Use a normal
<button>element. Some styles from the components package need to be replicated in the block, but this is fairly minimal.Testing Instructions
trunkin the editor