-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to prevent conversion of the original full-size JPEG file #1107
Comments
@adamdunnage Do you know what the user is trying to do? I feel like this is an edge case that is best achieved using code filters rather than adding a user control. Looking at the code, I think the user could short-circuit the conversion for full sized images using the Worth noting that even though we display WebP on the front end, we always maintain the original uploaded file so images can be regenerated in any supported format. |
Thank you for considering this. Indeed, a way to use that filter is mainly what I'm looking for, I just couldn't figure it out yet – For myself that would be enough. My issue is that some site owners are not comfortable displaying a file format different then the original, especially as sometimes images are in turn subject to approval by their own clients. With "thumbnails"/intermediate sizes, the conversion is accepted as they are seen as temporary and displayed in secondary locations. Except for that, dunno, I guess there might be some other use cases – such as legacy compatibility or photography websites – that could warrant making this a checkable option. |
Just in case anyone searches for this, it does seem to work with something like |
That looks good @luciandavidescu - note that the image size is passed to the the filter, so if you want you could limit this to just the 'full' size (see #307 for the original introduction of the filter). If others feel a checkbox is valuable I am not opposed to adding it, I'm glad you are unblocked in the mean time. |
Feature Description
As requested in the WebP Uploads support forum, could we give user the option to prevent conversion of the original full-size JPEG file?
This could be done via a specific piece of code or even an option in the plugin itself to give users the ability to switch the option on/off.
The text was updated successfully, but these errors were encountered: