Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PL plugin under plugins/performance-lab #1165

Closed
thelovekesh opened this issue Apr 19, 2024 · 2 comments · Fixed by #1182
Closed

Move PL plugin under plugins/performance-lab #1165

thelovekesh opened this issue Apr 19, 2024 · 2 comments · Fixed by #1182

Comments

@thelovekesh
Copy link
Member

Feature Description

As mentioned by @joemcgill in #1012 (comment), we should consider moving the PL to plugin to plugins dir.

@joemcgill
Copy link
Member

Thanks for opening an issue for this, @thelovekesh. It would be useful to get a list of all the things that would need to change in order to move PL into the plugins directory. For example, we would need to update our release scripts among other things.

Treating all of the plugins the same may simplify some things because we wouldn't need to treat PL separately from other plugins, but it would be good to understand how much effort it would be to make this transition before diving in.

@thelovekesh
Copy link
Member Author

Thanks @joemcgill. Currently, we're in the midst of decision-making, covering various aspects including the release process. Given this, I believe we can address everything together rather than focusing solely on the efforts required at this moment. Additionally, the build process already supports all necessary tooling and steps for the plugins directories.

Thus, aside from the release process, the only task left appears to be relocating the plugin contents to the plugins/performance-lab directory and removing PL plugin-specific workflows since all required steps will be covered as part of plugin workflows.

I initiated this now because it's currently causing us to duplicate efforts - once for the PL plugin and again for the rest of the plugins. By relocating the PL plugin to plugins, I believe we'll achieve better focus in a single location, both from a developer experience and perf feature addition perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants