Playground plugin: export data and catch load errors #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
adamziel
reviewed
Apr 5, 2024
| } | ||
| $user = get_user_by( 'id', ${playground.userId} ); | ||
| if( $user ) { | ||
| wp_set_current_user( $user->ID, $user->user_login ); |
There was a problem hiding this comment.
This could be moved to the login step in core
adamziel
reviewed
Apr 5, 2024
| resource: 'url', | ||
| url: playground.zipUrl, | ||
| }, | ||
| extractToPath: '/wordpress', |
There was a problem hiding this comment.
It just struck me that it's writing over the WordPress instance that's already in /wordpress. Oh well 🤷 Are we compressing the entire WordPress installation with wp-admin and wp-includes? I wonder if this step would be more appropriate:
{
"step": "importWordPressFiles",
"wordPressFilesZip": {
"resource": "url",
"url": playground.zipUrl
},
"progress": {
"weight": 20,
"caption": "Installing WordPress site"
}
}
There was a problem hiding this comment.
Or, even better:
features: {
networking: true,
},
preferredVersions: {
wp: playground.zipUrl,
php: playground.phpVersion
},
adamziel
approved these changes
Apr 5, 2024
|
Thanks! Both make sense and we will need to do it as part of enabling imports in Playground. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213 #208
What?
This PR adds support for exporting Playground data and implements an error modal when Playground fails to load.
Why?
We would like to allow users to export snapshots of their sites that can later be imported into Playground (a feature in Playground isn't implemented).
Some users reported errors like CORS issues and we need to ensure users have a next step to debug the issue.
How?
Playground snapshot is now an option in Tools > Export.
By catching errors while Playground is loading and displaying an alert.
Testing Instructions
playground.php