-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent dropdown content #1292
Comments
It looks like "Format" is a single-select, which intentionally has a different look/behavior to it — the visible title and lack of clear button (#1293) are intentional here. See WordPress/pattern-directory#648 (comment). You can see the same behavior on Showcase & Patterns: |
Thank you for sharing the rationale behind this! Feel that a single-select isn't suitable here because sorting doesn't filter out content, yet the Format reduces the visible content. Users would likely want to clear the filter. Or alternatively, like on Patterns, we could also add an "All" option and set it as the default. |
I was just about to comment to say the same thing 😄 |
I think we can get the same |
Yep, these options are set up here: wordcamp.org/public_html/wp-content/themes/wporg-events-2023/inc/events-query.php Lines 445 to 470 in 3d425fd
So you can add an "All" option there. |
Describe the bug
Based on other dropdowns and other latest themes, the title shouldn't be there inside the dropdown.
Expected behavior
Remove the text 'Format'.
Screenshots / Screencasts
The text was updated successfully, but these errors were encountered: