Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired GH artifact makes install via plugin-proxy.php seem broken #1359

Open
brandonpayton opened this issue May 2, 2024 · 3 comments
Open

Comments

@brandonpayton
Copy link
Member Author

This is blocking memory out-of-bounds repro for #1332 and likely affects others. I am looking into it.

@brandonpayton
Copy link
Member Author

It turns out that the artifact in the example case has expired. The CI job is re-running to hopefully create a new, unexpired artifact.

Artifact expiry is likely what I have seen when trying to test plugin-proxy.php with other old pull requests. It would be good for us to detect this and reflect it in the UI rather than failing a blueprint step and ending up in a strange limbo state.

@brandonpayton brandonpayton added [Type] Discussion and removed [Type] Bug An existing feature does not function as intended labels May 2, 2024
@brandonpayton brandonpayton changed the title Plugin install via plugin-proxy.php seems broken Expired GH artifact makes install via plugin-proxy.php seems broken May 2, 2024
@brandonpayton brandonpayton added [Type] Bug An existing feature does not function as intended [Type] UI / UX / User Experience and removed [Type] Discussion labels May 2, 2024
@brandonpayton brandonpayton changed the title Expired GH artifact makes install via plugin-proxy.php seems broken Expired GH artifact makes install via plugin-proxy.php seem broken May 3, 2024
@brandonpayton
Copy link
Member Author

The biggest aspect of this issue has been addressed by @bgrgicak in #1336. Now there is at least a message showing that the download failed:
Screenshot 2024-05-08 at 11 33 34 AM

But plugin-proxy.php could communicate the actual issue better if only in a way we can observe via the Network tab of dev tools.
Screenshot 2024-05-08 at 11 38 15 AM

Currently, it responds with "400 Bad request" when GitHub is responding with "410 Gone" which is more helpful than 400. Let's update plugin-proxy.php to communicate that info and update Playground to relay it in the error message.

@adamziel adamziel added this to the Zero Crashes milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants