Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Plugin Single Use of Color Failures #262

Open
amberhinds opened this issue Apr 16, 2024 · 9 comments
Open

Accessibility: Plugin Single Use of Color Failures #262

amberhinds opened this issue Apr 16, 2024 · 9 comments
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Site] Plugins [Status] Needs Design Feedback Feedback is needed on an existing or new component

Comments

@amberhinds
Copy link

On the plugin single page (Gutenberg plugin test page), there are several instances where links are indicated only by a change of color and do not have any other way to indicate that they are links. This is a failure of WCAG 1.4.1 Use of Color (A).

Here are the instances I found:

  1. "See all 56" - referring to languages in plugin meta:
Screenshot 2024-04-16 at 5 10 29 PM
  1. The Advanced View link:
Screenshot 2024-04-16 at 5 10 55 PM
  1. All of the rating links (both the number of stars "5 stars" and the count "821"):
Screenshot 2024-04-16 at 5 12 18 PM
  1. Contributors & Developer links:
Screenshot 2024-04-16 at 5 13 04 PM

Links need a second way, aside from color to indicate that they are links and actionable. Traditionally this is done with underlines, but arrows or other icons can also be used as an alternative.

@ryelle
Copy link
Contributor

ryelle commented Apr 16, 2024

I thought that only applies to links inside content? That these links, like the navigation links, were understood to be links by the context around them (being in the sidebar as "meta" info — the exception might be example 4). They also have underlines on hover, to help clarify.

For example, this pattern exists on Learn and Showcase, no underlines in the sidebar content until hover.

Screenshot 2024-04-16 at 6 24 42 PM Screenshot 2024-04-16 at 6 24 46 PM

@ryelle ryelle added Accessibility Issues related to keyboard navigation, screen readers, etc [Site] Plugins labels Apr 16, 2024
@amberhinds
Copy link
Author

It applies to links where you cannot clearly differentiate that it is a link. In the first example, maybe those are okay because they are all links and are a different weight from the text on the left. But in the second example that you posted, if you couldn't differentiate between the color blue and black, how would you know that "Business" is a link but "United States" is not?

@amberhinds
Copy link
Author

Essentially, people shouldn't have to hover over something to know that it's a link. Sometimes, positioning is enough to make it stand out as a link. But having some elements in a "table" (I know those are not tables, they just look like them) that are linked and others that are not, it's not sufficient to only use color to indicate which are links and which are not.

@ryelle
Copy link
Contributor

ryelle commented Apr 16, 2024

Okay, then I'll tag in @WordPress/meta-design since it sounds like we might need to revisit link styles across the entire redesign 😬

@ryelle ryelle added the [Status] Needs Design Feedback Feedback is needed on an existing or new component label Apr 16, 2024
@StevenDufresne
Copy link
Contributor

I'm not pushing back against this but interested in learning more.

For example, from the link you shared

WCAG 1.4.1 Use of Color (A).

The left-hand menu seems to also violate the rule based on the explanation.

Screenshot 2024-04-17 at 9 03 21 AM

Those are all links that are only discoverable after hover.

@amberhinds
Copy link
Author

The difference there is the context.

It's under a heading of "Table of Contents" which in and of itself may communicate to people (in a web scenario) that the items below the heading are all clickable. I think that communicates to people an expectation of functionality.

Also, every single thing in that list, styled that way is a link. There's not a mix of links and non-links that share the same styles in that list.

What I was getting at with my first comment is that it might be OK in some scenarios not to underline or have an icon if there's some other visual distinction between the link and adjacent text. While I don't love this, it might get a "pass" from some testers because everything on the right is a link and the links have a lower font-weight than the text at the left.

image

It's most problematic in scenarios like this where it's not clear if something is a link or not:
image

People might expect to be able to click on the author name or country. Or vice versa, if the first couple are not links and I can't distinguish the blue from the black, I wouldn't expect that I could click on the category or flavor.

@ndiego
Copy link
Member

ndiego commented Apr 17, 2024

Thanks for flagging this issue and the additional context 🙏

While we should definitely investigate and look into a design solution asap, I personally don't think it should block launching the new Plugins design since the link behavior is the same in the current theme (and elsewhere on the the site).

@fcoveram
Copy link

It could be a solution adding context to the area rather than modifying the font weight or adding an underline style? Given that the WCAG documentation example meets the requirement by clarifying the section purpose through a heading, we could include one in this section noting the meta content.

@joedolson
Copy link

It's pretty much entirely about whether a link is mixed with non-linked content. Even with a heading, the case with Author/Country/Category/Flavor/Published/Site tags posted above would fail, because some of those strings are linked and others aren't, and there's no way to distinguish between them.

The use of color criteria is about differentiating items: in this case, is it possible to differentiate a link from a non-link?

In the Table of Contents example from the W3C, there are several indicators that those are links: the heading 'Table of Contents', the background color that sets the content off from neighboring content, etc.,

If some of the text following the Table of Contents heading was linked and some of it wasn't, there would definitely be a problem there.

Following that logic, the example from Learn can pass; but the example from Showcase can't. It might be better if the Learn example had underlines, but I wouldn't actually call it a WCAG failure; being an accessibility problem and being a WCAG failure are two different things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Site] Plugins [Status] Needs Design Feedback Feedback is needed on an existing or new component
Projects
Status: 🛑 Pending discussion
Development

No branches or pull requests

6 participants