Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate Alignment from Indentation? #96

Open
GaryJones opened this issue Jul 22, 2022 · 2 comments
Open

Seperate Alignment from Indentation? #96

GaryJones opened this issue Jul 22, 2022 · 2 comments
Assignees

Comments

@GaryJones
Copy link
Member

We have a section in the PHP coding standards called Indentation:

Screenshot 2022-07-22 at 20 53 15

However, the first "exception" to it (second sentence) is about mid-line alignment. Would there be value in extracting this into a separate Alignment section? The presence of the "Rule of thumb" at the bottom of the section seems like a smell that these items could be documented separately.

@jrfnl
Copy link
Member

jrfnl commented Jul 22, 2022

Not sure if it needs a separate section, but improving the text of this section seems valid.

@dingo-d
Copy link
Member

dingo-d commented Jul 26, 2022

We could change the title to Indentation and Alignment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants