Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the title size in the 'More Information' section for a better appearance #370

Open
renintw opened this issue Nov 14, 2023 · 2 comments

Comments

@renintw
Copy link
Contributor

renintw commented Nov 14, 2023

In https://developer.wordpress.org/redesign-test/reference/functions/register_post_type/#more-information,
the font size of the title is too big. Should be adjusted based off the size of "More Information"

image
@renintw
Copy link
Contributor Author

renintw commented Nov 30, 2023

Context: All the content in the More Information section is edited and input by the user in the Editor.

@WordPress/meta-design Do you think we should reduce the size of the Taxonomies and Parameter detail information and the headings under them?
How much smaller should they be compared to "More Information"?

I might enforce a conversion of the user-inputted large-size headings into smaller sizes here.

@jasmussen
Copy link
Collaborator

Seems like the main question here is around the type scale of h1s to h6, where in this case Taxonimies is an h3 and h4 is appropriately smaller than that.

The parameters below those are definition lists, it appears. Could they have their dl sizes reduced? IMO they should not look like headings, they should just be body text size (font-size: 100%;), and perhaps bold.

If we need to review the type scale overall, we can do that, though is this not inherited from the global system? In that case we should be careful and deliberate.

One separate note. This border on the left to indicate you are looking at an anchor link isn't working that well:
Screenshot 2023-12-01 at 08 50 57

Do we actually need to highlight the anchor heading? Since you get scrolled to that heading as soon as you visit the link, my instinct would be not. Notably it feels a little confusing that the indicator remains, even when you scroll away.

If we do have to keep it due to some nuance I'm missing, then we should not add the left border and left padding, we could potentially do something like this instead:

Frame 1

That is, show the heading icon from the library left of the heading.

Also while I'm here, this link icon still looks squished and wrong compared to the link icon from that same icon library:

Screenshot 2023-12-01 at 08 57 58

I think it's reported separately, but would be good to fix.

@adamwoodnz adamwoodnz modified the milestones: MVP, Iteration 1 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants