Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Plugin Handbook: Plugin header examples should not be in one line of code #518

Open
juanmaguitar opened this issue May 8, 2024 · 4 comments
Labels
[Type] Bug Something isn't working

Comments

@juanmaguitar
Copy link

juanmaguitar commented May 8, 2024

As per feedback provided via Slack in the (Make WordPress) #docs channel

https://developer.wordpress.org/plugins/plugin-basics/header-requirements/
There is something wrong with docs.
plugin header should not be in one line of code

image

@justintadlock
Copy link

This looks like the same line break issue we had with the Dev Blog code syntax highlighter, which I believe uses a different plugin. We have the same issue on the Theme Handbook I noticed when adding new code blocks.

We implemented a quick fix for the Dev Blog here: WordPress/wporg-developer-blog#61

Related: WordPress/wporg-developer-blog#62

@ndiego ndiego added the [Type] Bug Something isn't working label May 8, 2024
@ndiego
Copy link
Member

ndiego commented May 8, 2024

cc @adamwoodnz

@adamwoodnz
Copy link
Contributor

I tried deactivating the Code Syntax plugin and found that the code comments did render correctly, so it seems the plugin does strip <br> tags.

However, I just edited the code block, deleting the line break and doing a soft return in visual mode, and then switched to code mode and all the <br> tags were gone. The comments now display as expected on the frontend. Do we know how the <br> tags are being created to start with?

Are there other pages we can look at with this issue?

@adamwoodnz
Copy link
Contributor

Looks like they were added by @audrasjb in this revision https://developer.wordpress.org/wp-admin/revision.php?revision=153510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants