Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"sameSite" Problem #14

Open
alfkoblischke opened this issue Jun 22, 2020 · 3 comments
Open

"sameSite" Problem #14

alfkoblischke opened this issue Jun 22, 2020 · 3 comments

Comments

@alfkoblischke
Copy link

Hi Wruczek,
the plugin is great, but I have a small problem regarding the "sameSite" attribute. In Firefox it says
that the "sameSite" attribute is "none" oder mnot guilty without a "secure"-attribute. Can you help.
regards Alf

@Wruczek
Copy link
Owner

Wruczek commented Jun 23, 2020

Hi there, can you explain why would you need a same-site attribute on a cookie alert? I dont think its needed.

@alfkoblischke
Copy link
Author

alfkoblischke commented Jun 23, 2020 via email

@duydao
Copy link

duydao commented Aug 30, 2020

@Wruczek Maybee this explanation will help: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite#Cookies_without_SameSite_default_to_SameSiteLax

Basically, there is a change comming to browsers on how cookies are handled. If we don't add the SameSite property, it will default to lax and give a warning to the console. Apps that will rely on accessing cookies from 3rd party pages will break either way, it doesn't matter if we add it or not. This change is applied with the current version of chrome, firefox will follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants