Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vario Gauge - Graphical Issues #1396

Open
4 of 5 tasks
lordfolken opened this issue Apr 6, 2024 · 8 comments · May be fixed by #1395
Open
4 of 5 tasks

Vario Gauge - Graphical Issues #1396

lordfolken opened this issue Apr 6, 2024 · 8 comments · May be fixed by #1395
Assignees
Milestone

Comments

@lordfolken
Copy link
Contributor

lordfolken commented Apr 6, 2024

Original
image

WIP:
image

Issues:

  • Labels NetAvg / Gross / MC are maligned e5b2ffc
  • The arc labels overflow the box 964d45e
  • The values under NetAvg/Gross/MC do not resize, the labels themselves do. 21fe2d0
  • The values should be large and the labels small 21fe2d0
  • arc is overlapping rc

I think a design along the butterfly vario, would be dooable and look good.

image

@lordfolken lordfolken linked a pull request Apr 6, 2024 that will close this issue
@lordfolken lordfolken self-assigned this Apr 6, 2024
@lordfolken lordfolken added this to the v7.43 milestone Apr 6, 2024
@DanD222
Copy link
Contributor

DanD222 commented Apr 7, 2024

I remember seeing the vario scale replaced by vector lines a while ago on the forum, might be worth looking into as well? The vario scale looks a lot better this way IMO.

https://forum.xcsoar.org/viewtopic.php?p=17530#p17530

0001-Replace-bitmap-vario-scale-by-drawn-lines.patch.txt

@lordfolken
Copy link
Contributor Author

None of this is a bitmap. I think that patch was merged long ago.

@DanD222
Copy link
Contributor

DanD222 commented Apr 7, 2024

Here’s the photo from the forum:
IMG_6491

It doesn’t look very similar to the current implementation to me.

None of this is a bitmap

You mean the two vario scales in your first post?

@lordfolken
Copy link
Contributor Author

lordfolken commented Apr 7, 2024

Yes. Neither scale is a bitmap. Its just maths and then rendered. The bitmap scale was removed some time ago.
Ill have a look at the patch. Maybe there is some inspiration there

@DanD222
Copy link
Contributor

DanD222 commented Apr 8, 2024

OK, thanks. Maybe see how it looks without the arc? (that doesn’t look all that great IMO)

@lordfolken
Copy link
Contributor Author

@DanD222 please review.

@DanD222
Copy link
Contributor

DanD222 commented Apr 8, 2024

Some first thoughts..

  • Looking at the B&W WIP screenshot in your first post, I think that the horizontal line at 0 lift/sink could be made shorter, so as to be the same length as the other lift/sink marks.

  • It seems to me that the lines at -3 and -4 are oriented towards a different point in the centre of the now imaginary arc than the lines at -1 and -2.

  • I'm not sure if it's doable to have the grey scale lift/sink numbers be "forward" of the white arrow?

  • I'm thinking whether the green arc shouldn't be more on the outside od the lift marks (possibly move the lift marks + labels more inwards so that the green bar doesn't run out of space)? Alternatively, are we able to have the green arc "behind" the white lift marks?

  • I'm also thinking about is whether the arrows shouldn't be touching/referenced to the right edge of the lines/green bar, instead of the current left edge. This might necessitate moving the numbers inwards a bit.

  • I would also consider making the NetAvg hollow arrow a bit thicker.

I don't use the vario display myself, so I'm not all that familiar with it, and had to think about what's displayed for a moment. I'm not sure if this is within the scope of what you're trying to improve, but:

  • The MC arrow is visually almost the most prominent element, while being the least useful one (compare to the tiny "Little gray pointer (reverse) with tip" on the Butterfly). I initially thought the MC arrow was the instantaneous/gross vario indicator.

Is that something we can also adjust perhaps? Could we colour-code the values in the centre of the vario scale the same way as the arrows on the vario (i.e. NetAvg, Gross, MC), so that there are visual cues as to which indicator is displaying which value, providing there's enough contrast so as to be able to differentiate between them on a B&W e-ink display?

@elgandoz
Copy link
Contributor

elgandoz commented Apr 9, 2024

Sorry to jump in, I would like to throw my 2 cents here... I quickly realised a mockup to test an improved display on the gauge, a bit more concentrical / symmetrical (like in the forum pic), using a more detailed scale (like the butterfly vario, or a classic analog one - see belove pic)
vario

The scale would work for both m/s and kt and it could be a more readable.
Also, just like the showcased varios, I believe there is no need to add the minus ["-"] sign in the negative scale, it just add noise in a small area.
Gauge

Given also the tiny space and the dimension of the scale numbers on a real screen, we could also consider to remove the scale numbers since the values are already visible within the Gross infobox at the center.

Gauge no scale

I'm not sure how easy this would be in code, I'm just trying to suggest how to improve the readability.

@lordfolken lordfolken modified the milestones: v7.43, v7.44 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
UI Improvements
Awaiting triage
Development

Successfully merging a pull request may close this issue.

3 participants