Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fullscreen: camera cutout area not used #1409

Open
elgandoz opened this issue Apr 26, 2024 · 2 comments
Open

[Android] Fullscreen: camera cutout area not used #1409

elgandoz opened this issue Apr 26, 2024 · 2 comments
Labels
android platform speciific issue enhancement
Milestone

Comments

@elgandoz
Copy link
Contributor

elgandoz commented Apr 26, 2024

XCSoar versions having and not having the problem

Which XCSoar version are you using when seeing the problem?

  • 7.42, 7.43-test

Which XCSoar version is the last one you know that did not show the problem?

  • TBC

System information

Pixel 6, Android 15 beta
Samsung S10e, Android 12

Steps to reproduce the behavior

  • Use an Android device with a camera cutout
  • Open XCSoar, with default settings
  • Enter either FLY or SIM mode
  • Observe black area covering the camera cutout
Screenshot
cutout area

Expected behavior

Maybe this is the expected behavior, but I personally think it would be much better having all the possible space available on screen, with the compromise of a tiny "blind spot".
This is what most of the Android apps are doing

Actual behavior

The whole camera cutout height is "reserved" with a black bar.

Do you have any idea what may have caused this?

Probably Android "immersive mode" has not been adapted since the pre-cutout phones era.

Do you have an idea how to solve the issue?

I'm not Android dev, but according to the specs we should add the instruction in the style.xml:

I can try to draft a PR

@elgandoz
Copy link
Contributor Author

Partially related to #1410

@lordfolken lordfolken added enhancement android platform speciific issue labels Apr 29, 2024
@lordfolken lordfolken added this to the v7.44 milestone Apr 29, 2024
@lordfolken
Copy link
Contributor

i tried LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES, i tried enabling notch true in the manifest. Sofar no luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android platform speciific issue enhancement
Projects
None yet
Development

No branches or pull requests

2 participants