{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":2724167,"defaultBranch":"develop","name":"rippled","ownerLogin":"XRPLF","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2011-11-07T04:40:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/67929741?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717542594.0","currentOid":""},"activityList":{"items":[{"before":"2d1854f354ff8bb2b5671fd51252c5acd837c433","after":"2df635693d54b8c17c428faf6ef99da2f14a9382","ref":"refs/heads/master","pushedAt":"2024-06-04T23:04:13.000Z","pushType":"push","commitsCount":67,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Set version to 2.2.0","shortMessageHtmlLink":"Set version to 2.2.0"}},{"before":"40b4adc9cc296a7e3c6e8c94b5a977a54c835613","after":"2df635693d54b8c17c428faf6ef99da2f14a9382","ref":"refs/heads/release","pushedAt":"2024-06-04T23:03:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Set version to 2.2.0","shortMessageHtmlLink":"Set version to 2.2.0"}},{"before":"40b4adc9cc296a7e3c6e8c94b5a977a54c835613","after":"2df635693d54b8c17c428faf6ef99da2f14a9382","ref":"refs/heads/develop","pushedAt":"2024-06-04T23:02:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Set version to 2.2.0","shortMessageHtmlLink":"Set version to 2.2.0"}},{"before":"d5e5c3c2206ea7790ec5fb140355345e46f6755f","after":"40b4adc9cc296a7e3c6e8c94b5a977a54c835613","ref":"refs/heads/release","pushedAt":"2024-05-21T02:19:22.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-rc3","shortMessageHtmlLink":"Set version to 2.2.0-rc3"}},{"before":"0c971b44154ad0f3bf5dc08d94f1f7b1171c48f5","after":"40b4adc9cc296a7e3c6e8c94b5a977a54c835613","ref":"refs/heads/develop","pushedAt":"2024-05-21T02:18:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-rc3","shortMessageHtmlLink":"Set version to 2.2.0-rc3"}},{"before":"f2d37da4ca12b8e3f897a46e370e5defd58621f6","after":"0c971b44154ad0f3bf5dc08d94f1f7b1171c48f5","ref":"refs/heads/develop","pushedAt":"2024-05-20T21:43:31.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Add xrpl.libpp as an exported lib in conan (#5022)","shortMessageHtmlLink":"Add xrpl.libpp as an exported lib in conan (#5022)"}},{"before":"d5e5c3c2206ea7790ec5fb140355345e46f6755f","after":"f2d37da4ca12b8e3f897a46e370e5defd58621f6","ref":"refs/heads/develop","pushedAt":"2024-05-20T20:33:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Fix Oracle's token pair deterministic order: (#5021)\n\nPrice Oracle data-series logic uses `unordered_map` to update the Oracle object.\r\nThis results in different servers disagreeing on the order of that hash table.\r\nConsequently, the generated ledgers will have different hashes.\r\nThe fix uses `map` instead to guarantee the order of the token pairs\r\nin the data-series.","shortMessageHtmlLink":"Fix Oracle's token pair deterministic order: (#5021)"}},{"before":"6974dfc6c2a7d17249b595477c39beceadca3a6a","after":null,"ref":"refs/heads/update-maintainers","pushedAt":"2024-05-17T00:07:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"intelliot","name":"Elliot Lee","path":"/intelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/81505?s=80&v=4"}},{"before":"02ec8b7962bfc1e046b85ab9414cfcf08be072b9","after":"d5e5c3c2206ea7790ec5fb140355345e46f6755f","ref":"refs/heads/release","pushedAt":"2024-05-16T22:10:51.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-rc2","shortMessageHtmlLink":"Set version to 2.2.0-rc2"}},{"before":"15390bedd5bd042d54a7ab8f0a0a96adbb83431e","after":"d5e5c3c2206ea7790ec5fb140355345e46f6755f","ref":"refs/heads/develop","pushedAt":"2024-05-16T22:09:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-rc2","shortMessageHtmlLink":"Set version to 2.2.0-rc2"}},{"before":"2705109592a56cb9800dca7664be91fc8cecc9de","after":"15390bedd5bd042d54a7ab8f0a0a96adbb83431e","ref":"refs/heads/develop","pushedAt":"2024-05-16T19:35:04.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Fix last Liquidity Provider withdrawal:\n\nDue to the rounding, LPTokenBalance of the last\nLiquidity Provider (LP), might not match this LP's\ntrustline balance. This fix sets LPTokenBalance on\nlast LP withdrawal to this LP's LPToken trustline\nbalance.","shortMessageHtmlLink":"Fix last Liquidity Provider withdrawal:"}},{"before":"244ac5e024f7151128db0288ab3c2bda5401f496","after":"2705109592a56cb9800dca7664be91fc8cecc9de","ref":"refs/heads/develop","pushedAt":"2024-05-14T19:28:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Add the fixAMMOfferRounding amendment: (#4983)\n\n* Fix AMM offer rounding and low quality LOB offer blocking AMM:\r\n\r\nA single-path AMM offer with account offer on DEX, is always generated\r\nstarting with the takerPays first, which is rounded up, and then\r\nthe takerGets, which is rounded down. This rounding ensures that the pool's\r\nproduct invariant is maintained. However, when one of the offer's side\r\nis XRP, this rounding can result in the AMM offer having a lower\r\nquality, potentially causing offer generation to fail if the quality\r\nis lower than the account's offer quality.\r\n\r\nTo address this issue, the proposed fix adjusts the offer generation process\r\nto start with the XRP side first and always rounds it down. This results\r\nin a smaller offer size, improving the offer's quality. Regardless if the offer\r\nhas XRP or not, the rounding is done so that the offer size is minimized.\r\nThis change still ensures the product invariant, as the other generated\r\nside is the exact result of the swap-in or swap-out equations.\r\n\r\nIf a liquidity can be provided by both AMM and LOB offer on offer crossing\r\nthen AMM offer is generated so that it matches LOB offer quality. If LOB\r\noffer quality is less than limit quality then generated AMM offer quality\r\nis also less than limit quality and the offer doesn't cross. To address\r\nthis issue, if LOB quality is better than limit quality then use LOB\r\nquality to generate AMM offer. Otherwise, don't use the quality to generate\r\nAMM offer. In this case, limitOut() function in StrandFlow limits\r\nthe out amount to match strand's quality to limit quality and consume\r\nmaximum AMM liquidity.","shortMessageHtmlLink":"Add the fixAMMOfferRounding amendment: (#4983)"}},{"before":"f4da2e31d93e921f1742a6c7c2120409cba4810e","after":"244ac5e024f7151128db0288ab3c2bda5401f496","ref":"refs/heads/develop","pushedAt":"2024-05-13T14:54:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Update CONTRIBUTING.md (#4904)","shortMessageHtmlLink":"Update CONTRIBUTING.md (#4904)"}},{"before":"a41720e92392d5e04302e810f97a767bff9ac6c7","after":"6974dfc6c2a7d17249b595477c39beceadca3a6a","ref":"refs/heads/update-maintainers","pushedAt":"2024-05-09T19:23:43.000Z","pushType":"push","commitsCount":59,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into update-maintainers","shortMessageHtmlLink":"Merge branch 'develop' into update-maintainers"}},{"before":"f6509495731b396ce33d96778e8df0366a8200bf","after":"f4da2e31d93e921f1742a6c7c2120409cba4810e","ref":"refs/heads/develop","pushedAt":"2024-05-09T19:17:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Price Oracle: validate input parameters and extend test coverage: (#5013)\n\n* Price Oracle: validate input parameters and extend test coverage:\r\n\r\nValidate trim, time_threshold, document_id are valid\r\nInt, UInt, or string convertible to UInt. Validate base_asset\r\nand quote_asset are valid currency. Update error codes.\r\nExtend Oracle and GetAggregatePrice unit-tests.\r\nDenote unreachable coverage code.\r\n\r\n* Set one-line LCOV_EXCL_LINE\r\n\r\n* Move ledger_entry tests to LedgerRPC_test.cpp\r\n\r\n* Add constants for \"None\"\r\n\r\n* Fix LedgerRPC test\r\n\r\n---------\r\n\r\nCo-authored-by: Scott Determan ","shortMessageHtmlLink":"Price Oracle: validate input parameters and extend test coverage: (#5013"}},{"before":"76128051c08b4038455edfa5f5acc9a1d31e8ba5","after":"f6509495731b396ce33d96778e8df0366a8200bf","ref":"refs/heads/develop","pushedAt":"2024-05-02T19:44:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Add external directory to Conan recipe's exports (#5006)","shortMessageHtmlLink":"Add external directory to Conan recipe's exports (#5006)"}},{"before":"5aa1106ba1fe25ee26dae34feeeed2136ba21bd7","after":"76128051c08b4038455edfa5f5acc9a1d31e8ba5","ref":"refs/heads/develop","pushedAt":"2024-05-02T15:14:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Add missing includes (#5011)","shortMessageHtmlLink":"Add missing includes (#5011)"}},{"before":"7ac63cd2aa0b53662cef05ab2e9dca2baf4a8c31","after":"3ba4f193c26e270d4f8c8957bdab874d194892b9","ref":"refs/heads/fix-4020","pushedAt":"2024-05-01T17:43:55.000Z","pushType":"push","commitsCount":68,"pusher":{"login":"intelliot","name":"Elliot Lee","path":"/intelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/81505?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into fix-4020","shortMessageHtmlLink":"Merge branch 'develop' into fix-4020"}},{"before":"dccf3f49ef35bedef76dd93e14fd071e34cd7f58","after":"5aa1106ba1fe25ee26dae34feeeed2136ba21bd7","ref":"refs/heads/develop","pushedAt":"2024-05-01T17:27:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Remove flow assert: (#5009)\n\nRounding in the payment engine is causing an assert to sometimes fire\nwith \"dust\" amounts. This is causing issues when running debug builds of\nrippled. This issue will be addressed, but the assert is no longer\nserving its purpose.","shortMessageHtmlLink":"Remove flow assert: (#5009)"}},{"before":"67286068ffe525d8dd3b96a8b989a413f2f71024","after":null,"ref":"refs/heads/nbougalis-patch-1","pushedAt":"2024-04-29T22:44:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"}},{"before":"02ec8b7962bfc1e046b85ab9414cfcf08be072b9","after":"dccf3f49ef35bedef76dd93e14fd071e34cd7f58","ref":"refs/heads/develop","pushedAt":"2024-04-29T22:44:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Update list of maintainers: (#4984)\n\nI am resigning from my role as maintainer of the `rippled` codebase.\r\n\r\nPlease update repository permissions accordingly, prior to merging this pull request.\r\n\r\nThanks to everyone who has contributed, especially those whom I had the opportunity to closely collaborate with.","shortMessageHtmlLink":"Update list of maintainers: (#4984)"}},{"before":"0fdb29be9bb9a4785a41d2d8727fcf40ddc24a1c","after":"67286068ffe525d8dd3b96a8b989a413f2f71024","ref":"refs/heads/nbougalis-patch-1","pushedAt":"2024-04-29T18:20:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into nbougalis-patch-1","shortMessageHtmlLink":"Merge branch 'develop' into nbougalis-patch-1"}},{"before":"676aae2755d0063cddce5bc4cd76bdccd55dd28c","after":"02ec8b7962bfc1e046b85ab9414cfcf08be072b9","ref":"refs/heads/release","pushedAt":"2024-04-26T23:00:49.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"intelliot","name":"Elliot Lee","path":"/intelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/81505?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-rc1","shortMessageHtmlLink":"Set version to 2.2.0-rc1"}},{"before":"3f7ce939c8cdea08d4161762e5d2a8d9d93c6790","after":"02ec8b7962bfc1e046b85ab9414cfcf08be072b9","ref":"refs/heads/develop","pushedAt":"2024-04-26T22:52:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-rc1","shortMessageHtmlLink":"Set version to 2.2.0-rc1"}},{"before":"777fb734c4ca50da32e46c2740ebe9aaca306593","after":"0fdb29be9bb9a4785a41d2d8727fcf40ddc24a1c","ref":"refs/heads/nbougalis-patch-1","pushedAt":"2024-04-26T02:06:44.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into nbougalis-patch-1","shortMessageHtmlLink":"Merge branch 'develop' into nbougalis-patch-1"}},{"before":"b422e71eed41d0c4c0ad93a90f51599185a67a61","after":"3f7ce939c8cdea08d4161762e5d2a8d9d93c6790","ref":"refs/heads/develop","pushedAt":"2024-04-26T01:15:19.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"fix amendment: AMM swap should honor invariants: (#5002)\n\nThe AMM has an invariant for swaps where:\nnew_balance_1*new_balance_2 >= old_balance_1*old_balance_2\n\nDue to rounding, this invariant could sometimes be violated (although by\nvery small amounts).\n\nThis patch introduces an amendment `fixAMMRounding` that changes the\nrounding to always favor the AMM. Doing this should maintain the\ninvariant.\n\nCo-authored-by: Bronek Kozicki\nCo-authored-by: thejohnfreeman","shortMessageHtmlLink":"fix amendment: AMM swap should honor invariants: (#5002)"}},{"before":"959cd242d7fcf838e78e8ff48a9e9ec6e9106f22","after":"777fb734c4ca50da32e46c2740ebe9aaca306593","ref":"refs/heads/nbougalis-patch-1","pushedAt":"2024-04-25T23:07:51.000Z","pushType":"push","commitsCount":22,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into nbougalis-patch-1","shortMessageHtmlLink":"Merge branch 'develop' into nbougalis-patch-1"}},{"before":"e9859ac1b16f8ab275955e89c05108f366327fd4","after":"b422e71eed41d0c4c0ad93a90f51599185a67a61","ref":"refs/heads/develop","pushedAt":"2024-04-25T17:05:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"thejohnfreeman","name":"John Freeman","path":"/thejohnfreeman","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1133852?s=80&v=4"},"commit":{"message":"chore: fix typos (#4958)","shortMessageHtmlLink":"chore: fix typos (#4958)"}},{"before":"b84f7e7c1022df82da33cc5db39632c3e2be44b2","after":"e9859ac1b16f8ab275955e89c05108f366327fd4","ref":"refs/heads/develop","pushedAt":"2024-04-24T17:54:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"test: Add RPC error checking support to unit tests (#4987)","shortMessageHtmlLink":"test: Add RPC error checking support to unit tests (#4987)"}},{"before":"676aae2755d0063cddce5bc4cd76bdccd55dd28c","after":"b84f7e7c1022df82da33cc5db39632c3e2be44b2","ref":"refs/heads/develop","pushedAt":"2024-04-19T18:41:33.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"thejohnfreeman","name":"John Freeman","path":"/thejohnfreeman","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1133852?s=80&v=4"},"commit":{"message":"Ignore more commits","shortMessageHtmlLink":"Ignore more commits"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEXIgwBAA","startCursor":null,"endCursor":null}},"title":"Activity ยท XRPLF/rippled"}