Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LedgerResult Deserialization: Invalid but parseable EscrowFinish fulfillment #513

Open
nkramer44 opened this issue Dec 18, 2023 · 1 comment · May be fixed by #512
Open

LedgerResult Deserialization: Invalid but parseable EscrowFinish fulfillment #513

nkramer44 opened this issue Dec 18, 2023 · 1 comment · May be fixed by #512
Milestone
LedgerResult Dese...

Comments

@nkramer44
Copy link
Collaborator

Certain fulfillments and conditions that show up in validated (but not executed) EscrowFinish transactions are able to be parsed by CryptoConditionReader, but are actually malformed (for example if a Fulfillment has a well formed first 32 bytes, but has extra bytes attached afterward). This causes an exception to be thrown when deserializing the EscrowFinish from JSON.

Offending transactions:
@nkramer44 nkramer44 linked a pull request Dec 18, 2023 that will close this issue
Open
@sappenin
Copy link
Collaborator

What should the fix logic be here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
LedgerResult Deserialization Issues
Development

Successfully merging a pull request may close this issue.

Fix EscrowFinish fulfillment and condition parsing XRPLF/xrpl4j
2 participants
@sappenin @nkramer44