Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Kubernetes experience #595

Open
laurivosandi opened this issue Aug 3, 2022 · 1 comment
Open

Improved Kubernetes experience #595

laurivosandi opened this issue Aug 3, 2022 · 1 comment
Labels
enhancement The issue is related to improving a certain aspect of the project. triaged The issue has been reviewed but has not been solved yet.

Comments

@laurivosandi
Copy link

Currently detect-secrets considers secretName values in Kubernetes manifests as secrets, whereas they are actually merely names of the secrets.

Also looks like line numbering gets messed up with multi-line scalar values https://yaml.org/spec/1.2-old/spec.html#id2795688
@lorenzodb1 lorenzodb1 added the pending The issue still needs to be reviewed by one of the maintainers. label Aug 24, 2022
@DeamonMV
Copy link

DeamonMV commented Aug 2, 2023

I can add some context - Plugin trigers on any "Secret" word in Helm of Kubernetes manifest
For example:

  • nginx.ingress.kubernetes.io/auth-secret
  • existingSecret

@lorenzodb1 lorenzodb1 added triaged The issue has been reviewed but has not been solved yet. enhancement The issue is related to improving a certain aspect of the project. and removed pending The issue still needs to be reviewed by one of the maintainers. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is related to improving a certain aspect of the project. triaged The issue has been reviewed but has not been solved yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laurivosandi @DeamonMV @lorenzodb1