Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Configuration File #655

Open
1 task done
bdellegrazie opened this issue Jan 10, 2023 · 1 comment
Open
1 task done

Support for Configuration File #655

bdellegrazie opened this issue Jan 10, 2023 · 1 comment
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. P4 Future work. E.g. something we might to get on in the future. Might be used for future ideas too. request The issue is a request for a new feature or plugin. triaged The issue has been reviewed but has not been solved yet.

Comments

@bdellegrazie
Copy link

  • I'm submitting a ...

    • feature request
  • What is the current behavior?
    Detect secrets only accepts command line options for configuration

  • What is the expected behavior?
    I'd like detect secrets to be able to take a configuration file where the common options can be set for use both by the command line and in a pre-commit hook.
    This makes it easier / simpler to consistently use filter lists and get the same behaviour in a pre-commit hook and by the command line.

  • What is the motivation / use case for changing the behavior?
    Simpler command line usage in concert with pre-commit hook usage.
    It's certainly possible to do this with a shell script wrapper but that changes the invocation in pre-commit. It's pretty common
    for tools of this nature to support a configuration file (e.g. yamllint, eslint etc.) for exactly this reason

  • Please tell us about your environment:

    • detect-secrets Version: latest 1.4.0
    • Python Version: 3.9.9 / 3.10.6 / 3.11.0
    • OS Version: Ubuntu 22.04, MacOS latest
    • File type (if applicable): N/A
@jpdakran jpdakran added pending The issue still needs to be reviewed by one of the maintainers. request The issue is a request for a new feature or plugin. P4 Future work. E.g. something we might to get on in the future. Might be used for future ideas too. triaged The issue has been reviewed but has not been solved yet. and removed pending The issue still needs to be reviewed by one of the maintainers. labels Mar 22, 2023
@lorenzodb1
Copy link
Member

Hi @bdellegrazie, thank you for submitting this feature request!

@jpdakran and I have discussed this feature in the past and we believe it would be a great addition to detect-secrets. We added this on our to-do list, but since such a change would probably require a major release, it might take some time before it'll get implemented and released. We'll make sure to keep you posted on it, though.

@lorenzodb1 lorenzodb1 added help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. good first issue The issue can be tackled by someone who has little to no knowledge about the project. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. P4 Future work. E.g. something we might to get on in the future. Might be used for future ideas too. request The issue is a request for a new feature or plugin. triaged The issue has been reviewed but has not been solved yet.
Projects
None yet
Development

No branches or pull requests

3 participants