Improve AceBase support #4557
Improve AceBase support #4557
Conversation
* use `.child` instead of string concats on paths * remove unnecessary `limit(999999)` for queries with filters * use `.get` instead of `.query` to get all data * using `skip` and `limit` args of `GetAllTypeNoTypeFieldMeshFiltered` * use `==` instead of `in` operator in `RemoveSMBIOS` and `GetSMBIOS` * use `.count` insetad of `.get` in `getDbStats` * use `.get` instead of `.query` in `getPlugins`, custom sort function
|
This pull request introduces 1 alert and fixes 2 when merging 883f9ff into b51108a - view on LGTM.com new alerts:
fixed alerts:
|
|
I've just published AceBase v1.24.4 which should drastically improve |
|
Oh wow! Thank you!!! I don't know of anyone running MeshCentral in any real way using AceBase, so this is the perfect time to make these improvements. Given that the AceBase code in MeshCentral is isolated from the rest, I will gladly merge this in even if it's not perfect. Thank you for looking into the record delete issue. I would have a good sized database with lots of events and change the configuration of MeshCentral to only keep events for a few minutes forcing the removal of lots of older events, that would jam up MeshCentral and did cause me to pause on using AceBase. Looking at your changes, the typo in "MeshCentral" for the indexes caused me to hit my head a few times, well done. I am on vacation until October 18th, but anytime you feel you want me to merge, let me know, I will gladly do it. |
Hi @Ylianst I've taken the liberty to improve the AceBase implementation in MeshCentral. I have not tested the changes yet, will do so asap.
I have also taken a look at why you were seeing slow performance on your
removequeries, I will be releasing a new version of AceBase tomorrow that will drastically improve this. Will keep you updated on this.If there are other issues you would want to bring to my attention, please do so. I'm happy to help.