Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invite HTTP url doesnt redirect to HTTPS #4622

Closed
si458 opened this issue Oct 11, 2022 · 6 comments
Closed

invite HTTP url doesnt redirect to HTTPS #4622

si458 opened this issue Oct 11, 2022 · 6 comments
Assignees
@Ylianst
Labels
bug Fixed - Please Verify & Close

Comments

@si458
Copy link
Collaborator

si458 commented Oct 11, 2022 •
edited

Describe the bug
when i visit http://meshcentral.myserver.com/invite i was expecting the invite page, instead i get a 404 error

To Reproduce
Steps to reproduce the behavior:

  1. enable invite codes
  2. set invite code
  3. visit http://meshcentral.myserver.com/invite

Expected behavior
when visiting the invite url in HTTP i expected it to divert to HTTPS but it displays HTTP 404 instead

Screenshots
If applicable, add screenshots to help explain your problem.

Server Software (please complete the following information):

  • OS: [e.g. Ubuntu] Ubuntu 22.04
  • Virtualization: [e.g. Docker] N/A
  • Network: [e.g. LAN/WAN, reverse proxy, cloudflare, ssl offload, etc...] Hybrid, Lets Encrypt, Direct
  • Version: [e.g. 1.0.43] 1.0.85
  • Node: [e.g. 18.4.0] 16.17.1

Client Device (please complete the following information):

  • Device: [e.g. Laptop] Laptop
  • OS: [e.g. Ubuntu] Windows 11 Pro
  • Network: [e.g. Local to Meshcentral, Remote over WAN] WAN
  • Browser: [e.g. Google Chrome] ANY
  • MeshCentralRouter Version: [if applicable] N/A

Remote Device (please complete the following information):

  • Device: [e.g. Laptop]
  • OS: [e.g. Windows 10 21H2]
  • Network: [e.g. Local to Meshcentral, Remote over WAN]
  • Current Core Version (if known): [HINT: Go to a device then console Tab then type info]

Additional context

simon@mybillybob:~$ curl http://meshcentral.myserver.com/invite -v
*   Trying 217.1.1.1:80...
* Connected to meshcentral.myserver.com (217.1.1.1) port 80 (#0)
> GET /invite HTTP/1.1
> Host: meshcentral.myserver.com
> User-Agent: curl/7.81.0
> Accept: */*
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 404 Not Found
< strict-transport-security: max-age=60000; includeSubDomains
< Referrer-Policy: no-referrer
< x-frame-options: SAMEORIGIN
< X-XSS-Protection: 1; mode=block
< X-Content-Type-Options: nosniff
< Content-Security-Policy: default-src 'none'
< Content-Type: text/html; charset=utf-8
< Content-Length: 145
< Date: Tue, 11 Oct 2022 08:45:33 GMT
< Connection: keep-alive
< Keep-Alive: timeout=5
< 
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>Error</title>
</head>
<body>
<pre>Cannot GET /invite</pre>
</body>
</html>
* Connection #0 to host meshcentral.myserver.com left intact

Your config.json file

N/A
@si458 si458 added the bug label Oct 11, 2022
@OutbackMatt
Copy link

What Web Server software are you using?
Nginx or Apache2 or ....

That's where you need to set redirects to to HTTPS

@si458
Copy link
Collaborator Author

si458 commented Oct 11, 2022 •
edited

What Web Server software are you using? Nginx or Apache2 or ....

That's where you need to set redirects to to HTTPS

im using it directly so the is not web server, meshcentral running on port 80 and 443

EDIT:

i can see its redirectly correct, just not the invite url for some reason

simon@mybillybob:~# curl http://meshcentral.myserver.com -v
*   Trying 217.1.1.1:80...
* Connected to meshcentral.myserver.com (217.1.1.1) port 80 (#0)
> GET / HTTP/1.1
> Host: meshcentral.myserver.com
> User-Agent: curl/7.81.0
> Accept: */*
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 302 Found
< strict-transport-security: max-age=60000; includeSubDomains
< Referrer-Policy: no-referrer
< x-frame-options: SAMEORIGIN
< X-XSS-Protection: 1; mode=block
< X-Content-Type-Options: nosniff
< Content-Security-Policy: default-src 'none'; style-src 'self' 'unsafe-inline';
< Location: https://meshcentral.myserver.com:443/
< Vary: Accept
< Content-Type: text/plain; charset=utf-8
< Content-Length: 56
< Date: Tue, 11 Oct 2022 13:38:24 GMT
< Connection: keep-alive
< Keep-Alive: timeout=5
< 
* Connection #0 to host meshcentral.myserver.com left intact
Found. Redirecting to https://meshcentral.myserver.com:443/

@Ylianst Ylianst self-assigned this Oct 25, 2022
@Ylianst
Copy link
Owner

Ylianst commented Oct 25, 2022

Oh. Good bug, working on it now.

@Ylianst
Copy link
Owner

Ylianst commented Oct 25, 2022

Confirmed, I see the same issue. Working on it.

Ylianst added a commit that referenced this issue Oct 25, 2022
@Ylianst
Added invite HTTP to HTTPS redirect (#4622)
2981217
@Ylianst
Copy link
Owner

Ylianst commented Oct 25, 2022

Ok, easy fix. Thank you for reporting this. Will be in v1.0.90.

@si458
Copy link
Collaborator Author

si458 commented Oct 30, 2022

Bingo thanks

@si458 si458 closed this as completed Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ylianst Ylianst

Labels
bug Fixed - Please Verify & Close
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@si458 @Ylianst @OutbackMatt