Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.87 - Terminal - Connect is not working on non-english pages. #4663

Closed
rapi3 opened this issue Oct 24, 2022 · 8 comments
Closed

v1.0.87 - Terminal - Connect is not working on non-english pages. #4663

rapi3 opened this issue Oct 24, 2022 · 8 comments

Comments

@rapi3
Copy link

rapi3 commented Oct 24, 2022

Describe the bug
Pressing Connect on Terminal - nothing happens ( reverting to v1.0.85 it is working OK )

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Agent - Terminal'
  2. Click on 'Connect'

Expected behavior
Connect to terminal on remote agent.

Screenshots
no

Server Software (please complete the following information):

  • OS: Ubuntu 22.04.1 LTS
  • Network: LAN/WAN
  • Version: 1.0.87
  • Node: v16.13.2

Client Device (please complete the following information):

  • Device: Laptop/PC
  • OS: Ubuntu
  • Network: Local to Meshcentral
  • Browser: Chrome

Remote Device (please complete the following information):

  • Device: Laptop/PC
  • OS: Ubuntu / Linux
  • Network: Local to Meshcentral
  • Current Core Version (if known): Aug 29 2022, 294730201
@rapi3 rapi3 added the bug label Oct 24, 2022
@krayon007
Copy link
Collaborator

I think xterm.js was updated in that version, so let me do some testing with the updated xterm.

@si458
Copy link
Collaborator

si458 commented Oct 24, 2022

Not having this issue here?
Updated to 1.0.87 and connected to Ubuntu centos and debian no problems
Have you tried ctrl+f5?
Also logging out and back in again?
Also try private browsing?

@Ylianst
Copy link
Owner

Ylianst commented Oct 24, 2022

One possible problem is that old files are cached. Hold the "Shift" key and hit refresh on the browser and try again. My first guess that that the old xterm.js is being served with a new main web site. Let me know if that solves it.

An ideal fix would be to put a version number of the files so that, even if cached, the updated version would get loaded.

@nicrame
Copy link
Contributor

nicrame commented Oct 24, 2022

I can confirm problem on windows terminal (v 1.0.87 and 1.0.88 - cache cleared from browser, using newest FF).
It looks like that:
Zrzut ekranu (23)
Same problem with Linux agents.

@Ylianst
Copy link
Owner

Ylianst commented Oct 24, 2022

Ok, looking into it.

@Ylianst
Copy link
Owner

Ylianst commented Oct 24, 2022

Your right! It works in English but not in other languages. Looking for a fix now. Thank you for the screen shot, I noticed it was not English and tried it and saw the problems right away.

@Ylianst Ylianst changed the title v1.0.87 - Terminal - Connect is not working on linux agent / windows not tested. v1.0.87 - Terminal - Connect is not working on non-english pages. Oct 24, 2022
@Ylianst
Copy link
Owner

Ylianst commented Oct 24, 2022

MeshCentral v1.0.89 published with a fix for this. Let me know if it works.

@rapi3
Copy link
Author

rapi3 commented Oct 25, 2022

It is fixed in v1.0.89.
Thank you.

@rapi3 rapi3 closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants