Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Handle removed assertEqualXMLStructure() assertion #3

Closed
jrfnl opened this issue Oct 26, 2020 · 5 comments
Closed

[FR] Handle removed assertEqualXMLStructure() assertion #3

jrfnl opened this issue Oct 26, 2020 · 5 comments

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Oct 26, 2020

The Assert::assertEqualXMLStructure() assertion was deprecated in PHPUnit 9.1.0 and will be removed in PHPUnit 10.0.0 without replacement.

Polyfilling this would require copying most of the code which will be removed from PHPUnit, which I'm hesistant to do.

Refs:

@stof
Copy link

stof commented Oct 26, 2020

As this library is described as a forward-compatibility polyfill, I would say that adding back support for removed assertions is out of scope.
The forward-compatibility polyfill would be to remove these assertions on older versions too, which would be weird.

@jrfnl
Copy link
Collaborator Author

jrfnl commented Oct 26, 2020

@stof Exactly why it hasn't been done yet. I've opened issues for several of these removals to see how much need/interest there is to polyfill them anyway and we'll take it from there based on 👍 / 👎 's.

@jrfnl
Copy link
Collaborator Author

jrfnl commented Dec 4, 2020

Update: the removal has been executed in PHPUnit upstream: sebastianbergmann/phpunit@47a2d92

@jrfnl
Copy link
Collaborator Author

jrfnl commented Jun 12, 2021

Update: there is discussion about replacing the functionality with different, improved implementations in: sebastianbergmann/phpunit#4091
Also see: sebastianbergmann/phpunit#4507

@jrfnl
Copy link
Collaborator Author

jrfnl commented Aug 24, 2022

Not seeing any movement on this upstream, nor significant interest here, so I'm closing this issue. If upstream decides to add a replacement, we'll deal with it, but there nothing to do until that time.

@jrfnl jrfnl closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants