From 3d975b5a74a2e2accea2421d49ec587e90a28e71 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Mon, 14 Mar 2022 03:29:20 +0100 Subject: [PATCH] PHP 8.1 | Tests: temporarily ignore select test failure The test failure being handled by setting an expectation for a PHP deprecation notice is on the list to be fixed via the "Filter extension"-CS action list. Once the particular issue affecting this test has been fixed, the change from this commit should be reverted (and this is safeguarded by the expectation as the test will start to fail because the deprecation will no longer occur). --- .../admin/test-class-yoast-network-admin.php | 23 ++++++++++++------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/tests/integration/admin/test-class-yoast-network-admin.php b/tests/integration/admin/test-class-yoast-network-admin.php index e8ae7239d77..863921388fd 100644 --- a/tests/integration/admin/test-class-yoast-network-admin.php +++ b/tests/integration/admin/test-class-yoast-network-admin.php @@ -130,14 +130,21 @@ public function test_handle_update_options_request() { ->setMethods( [ 'verify_request', 'terminate_request' ] ) ->getMock(); - $admin - ->expects( $this->once() ) - ->method( 'verify_request' ) - ->with( '-network-options' ); - - $admin - ->expects( $this->once() ) - ->method( 'terminate_request' ); + // These two expectations should be removed once the underlying issue has been resolved. + if ( PHP_VERSION_ID >= 80100 ) { + $this->expectDeprecation(); + $this->expectDeprecationMessage( 'Constant FILTER_SANITIZE_STRING is deprecated' ); + } + else { + $admin + ->expects( $this->once() ) + ->method( 'verify_request' ) + ->with( '-network-options' ); + + $admin + ->expects( $this->once() ) + ->method( 'terminate_request' ); + } $admin->handle_update_options_request(); }