Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with Easy Digital Downloads Software Licensing since v20.4 #21389

Open
4 of 9 tasks
Dan0sz opened this issue May 17, 2024 · 5 comments
Open
4 of 9 tasks

Comments

@Dan0sz
Copy link

Dan0sz commented May 17, 2024

I wanted to report that, since v20.4, this plugin breaks the license renewal links for logged-out users in Easy Digital Downloads’ Software Licensing add-on.

Steps to reproduce the issue:

  1. Rollback to Yoast SEO v20.3 on a system with Easy Digital Downloads and Software Licensing installed and configured.
  2. Follow any license renewal links in a private window (to make sure that you’re a not logged-in user), e.g. https://yourdomain.com/checkout/?nocache=true&edd_license_key=123456789&download_id=1234
  3. You should now see a checkout page, with the product’s license renewal all setup. The user only has to fill out address and email information (or log in, of course)
  4. Now, rollback to Yoast SEO v20.4 or higher on that same system and follow the same steps.
  5. You’ll see that you get a “Your cart is empty” notice on screen and you’re unable to continue checkout.

I only just found out about it. Hopefully this can be resolved soon, because I can’t activate Premium on 20.3.

Expected results

  1. A checkout page, with the license renewal all setup in the cart.

Actual results

  1. An empty cart.

Technical info

  • If relevant, which editor is affected (or editors):
  • Block Editor
  • Gutenberg Editor
  • Elementor Editor
  • Classic Editor
  • Other:
  • Which browser is affected (or browsers):
  • Chrome
  • Firefox
  • Safari
  • Other:

Used versions

  • Device you are using:
  • Operating system: Any
  • PHP version: 8.1
  • WordPress version: 6.5.3
  • WordPress Theme: Astra
  • Yoast SEO version: 20.4 and up
  • Relevant plugins in case of a bug: Easy Digital Downloads, EDD Software Licensing (add-on)
@josevarghese
Copy link
Contributor

Hi @Dan0sz

Thanks for using the Yoast SEO plugin and also for creating the issue. From the version you mentioned, it seems like one of the features of crawl optimization introduced in version 20.4 appears to be the reason for this anomaly.

So as the first step to narrow down the issue, can you please navigate to the Yoast SEO > Settings > Crawl Optimization > Advanced: URL cleanup and check whether you have manually enabled the Remove unregistered URL parameters or not? If yes, toggle off the settings and check the URL again on an new incognito window. If the issue persists please let us know.

We look forward to hearing from you and are happy to help you.

@Dan0sz
Copy link
Author

Dan0sz commented May 20, 2024

Hi! Thanks for your reply.

The Crawl Optimization part seems to be a premium feature, which I have disabled now. The issue occurs in the free version of Yoast SEO.

@josevarghese
Copy link
Contributor

Hi @Dan0sz

We are providing the Crawl Optimization settings with the Yoast SEO free plugin, and only some bot-blocking features via robots.txt are only limited to the Yoast SEO Premium plugin features.

As the renewal link cannot be set up using the free EDD plugin available on WordPress.org and as I didn't have an EDD Software Licensing (add-on), can you share any renewal URLs from your staging site to check this further?

We look forward to hearing from you.

@Dan0sz
Copy link
Author

Dan0sz commented May 21, 2024

Ah! In 20.3 they still were premium features. Hence my comment. Just updated, disabled the option, and now it works! Enabled premium, and it still works. Nice!

My staging site is locked with basic auth. Can I DM you somehow to share the credentials?

@josevarghese
Copy link
Contributor

Yes, we changed the Crawl Optimization features from the premium to the free plugin in version 20.10. If the issue persists with the latest versions of Yoast SEO 22.7 and Yoast SEO Premium 22.7, kindly email support@yoast.com with the website URL and page URL. Ensure that both plugins are updated to the latest version.

Our support team will look into this further to help you via support, as you already have a premium plugin and subscription.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants